[velux] Bridge status shows offline when communication fails #13406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
the
enhancement
lolodomo
reviewed
Sep 18, 2022
...nding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxBridgeHandler.java
Outdated
Show resolved
Hide resolved
|
Your approach is relatively unusual. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…nhab-addons into 13383-velux-offline
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
I agree with you that it is rather unusual (I did not write this part of the code). However you may have missed the peculiarity that the |
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…#13406) * [velux] dynamically update bridge on-/off- line state Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
seime
pushed a commit
to seime/openhab2-addons
that referenced
this pull request
Oct 16, 2022
…#13406) * [velux] dynamically update bridge on-/off- line state Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…#13406) * [velux] dynamically update bridge on-/off- line state Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…#13406) * [velux] dynamically update bridge on-/off- line state Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
…#13406) * [velux] dynamically update bridge on-/off- line state Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…#13406) * [velux] dynamically update bridge on-/off- line state Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…#13406) * [velux] dynamically update bridge on-/off- line state Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13383
Background
As reported in issue #13383 the bridge thing does not indicate offline status when when the communication fails.
Solution
In this PR the bridge thing status will change to offline when the communication fails, and return to online when it is restored.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch