Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tibber] Add channel for tomorrows prices and timestamps as JSON array #13416

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

seime
Copy link
Contributor

@seime seime commented Sep 19, 2022

Allows users to build rules based on tomorrow's electricity cost.

Should be rewritten if openhab/openhab-core#3000 is accepted in one or another form some time in the future. Until then, this PR helps.

@seime seime requested a review from kjoglum as a code owner September 19, 2022 14:42
Signed-off-by: Arne Seime <arne.seime@gmail.com>
Copy link
Contributor

@kjoglum kjoglum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Sep 19, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added some very minor comments.

Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 9313310 into openhab:main Oct 11, 2022
@jlaur jlaur added this to the 3.4 milestone Oct 11, 2022
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
openhab#13416)

Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants