-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tibber] Add channel for tomorrows prices and timestamps as JSON array #13416
Conversation
Signed-off-by: Arne Seime <arne.seime@gmail.com>
71165e2
to
89169ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've added some very minor comments.
bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Arne Seime <arne.seime@gmail.com>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Arne Seime <arne.seime@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
openhab#13416) Signed-off-by: Arne Seime <arne.seime@gmail.com>
openhab#13416) Signed-off-by: Arne Seime <arne.seime@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
openhab#13416) Signed-off-by: Arne Seime <arne.seime@gmail.com>
openhab#13416) Signed-off-by: Arne Seime <arne.seime@gmail.com>
openhab#13416) Signed-off-by: Arne Seime <arne.seime@gmail.com>
Allows users to build rules based on tomorrow's electricity cost.
Should be rewritten if openhab/openhab-core#3000 is accepted in one or another form some time in the future. Until then, this PR helps.