Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remoteopenhab] Optimize filtering of ALIVE events #13432

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Sep 23, 2022

Signed-off-by: Laurent Garnier lg.hc@free.fr

Depends on openhab/openhab-core#3086

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Sep 23, 2022
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@J-N-K
Copy link
Member

J-N-K commented Sep 25, 2022

I believe this does not depend on the core PR but should be merged before, correct?

@lolodomo
Copy link
Contributor Author

I believe this does not depend on the core PR but should be merged before, correct?

As the current alive event has "event" as name, I believe you are right.

@lolodomo lolodomo removed the awaiting other PR Depends on another PR label Sep 25, 2022
@lolodomo
Copy link
Contributor Author

So, to be clear, this PR is working with and without the core PR changing the alive event.

@lolodomo lolodomo changed the title [remoteopenhab] Optimize handling of ALIVE events [remoteopenhab] Optimize filtering of ALIVE events Sep 25, 2022
@lolodomo
Copy link
Contributor Author

Can this very small PR be merged please?
@jlaur or @fwolter

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit d00ca1c into openhab:main Sep 28, 2022
@jlaur jlaur added this to the 3.4 milestone Sep 28, 2022
@lolodomo lolodomo deleted the remoteoh_alive_event branch September 28, 2022 18:42
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
* [remoteopenhab] Optimize handling of ALIVE events

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
seime pushed a commit to seime/openhab2-addons that referenced this pull request Oct 16, 2022
* [remoteopenhab] Optimize handling of ALIVE events

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [remoteopenhab] Optimize handling of ALIVE events

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [remoteopenhab] Optimize handling of ALIVE events

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
* [remoteopenhab] Optimize handling of ALIVE events

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [remoteopenhab] Optimize handling of ALIVE events

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [remoteopenhab] Optimize handling of ALIVE events

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants