Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netatmo] Room-Thing offline after restart #13467

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Sep 30, 2022

Correcting issue by late loading of the capability.
Resolves #13403
Signed-off-by: clinique gael@lhopital.org

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from lolodomo as a code owner September 30, 2022 06:46
@clinique
Copy link
Contributor Author

clinique commented Sep 30, 2022

This solves also these warning raised at OH startup:

2022-09-30 08:50:33.091 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler ModuleHandler of thing netatmo:room:home:59959297b4809d1aff8b4726:dining tried accessing its bridge although the handler was already disposed.
2022-09-30 08:50:33.130 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler ModuleHandler of thing netatmo:room:home:59959297b4809d1aff8b4726:office tried accessing its bridge although the handler was already disposed.
2022-09-30 08:50:33.213 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler ModuleHandler of thing netatmo:room:home:59959297b4809d1aff8b4726:parents tried accessing its bridge although the handler was already disposed.
2022-09-30 08:50:33.275 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler ModuleHandler of thing netatmo:room:home:59959297b4809d1aff8b4726:kitchen tried accessing its bridge although the handler was already disposed.

Signed-off-by: clinique <gael@lhopital.org>
@jlaur
Copy link
Contributor

jlaur commented Sep 30, 2022

@clinique - if you change "Solves issue" to "Resolves" in the PR description, the issue will be automatically linked and closed upon PR completion. :)

@jlaur
Copy link
Contributor

jlaur commented Sep 30, 2022

@clinique - if you change "Solves issue" to "Resolves" in the PR description, the issue will be automatically linked and closed upon PR completion. :)

To be clear: "Resolves #xxxxx", not "Resolves issue #xxxxx" - still not linked.

@jlaur jlaur linked an issue Sep 30, 2022 that may be closed by this pull request
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Sep 30, 2022
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

lolodomo commented Oct 1, 2022

@clinique ! you arre now avoiding to retry the API request in case the API limit is reached but you agree that this is not a fix for #13358 ?

@lolodomo lolodomo merged commit cedf6d9 into openhab:main Oct 1, 2022
@lolodomo lolodomo added this to the 3.4 milestone Oct 1, 2022
@clinique
Copy link
Contributor Author

clinique commented Oct 1, 2022

@clinique ! you arre now avoiding to retry the API request in case the API limit is reached but you agree that this is not a fix for #13358 ?

It should fix it. The thing being I did not find how many time we've got to wait when Api limit is reached.

@clinique
Copy link
Contributor Author

clinique commented Oct 1, 2022

I've got another issue to fix. From time to time API does not answer to camera pings (TimeoutException, most of the time in the middle of the night) and then the binding goes on error. I'll study this once this PR is available to see how it behaves.

@clinique clinique deleted the netatmo_13403 branch October 1, 2022 11:28
@lolodomo
Copy link
Contributor

lolodomo commented Oct 1, 2022

@clinique ! you arre now avoiding to retry the API request in case the API limit is reached but you agree that this is not a fix for #13358 ?

It should fix it. The thing being I did not find how many time we've got to wait when Api limit is reached.

I see nothing new in that PR that could avoid reaching the API limit.
Please develop.

@clinique
Copy link
Contributor Author

clinique commented Oct 1, 2022

Sorry. Misunderstood. It not meant to avoid reaching API limit but rather handle it more gracefully

@lolodomo
Copy link
Contributor

lolodomo commented Oct 1, 2022

Sorry. Misunderstood. It not meant to avoid reaching API limit but rather handle it more gracefully

So we agree.
The issue #13358 is more how to fix the binding to avoid reaching that limit.

leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
* Correcting issue by late loading of the capability.
* Handle MAXIMUM_USAGE_REACHED at ApiBridgeHandler level.

Signed-off-by: clinique <gael@lhopital.org>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Correcting issue by late loading of the capability.
* Handle MAXIMUM_USAGE_REACHED at ApiBridgeHandler level.

Signed-off-by: clinique <gael@lhopital.org>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* Correcting issue by late loading of the capability.
* Handle MAXIMUM_USAGE_REACHED at ApiBridgeHandler level.

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
* Correcting issue by late loading of the capability.
* Handle MAXIMUM_USAGE_REACHED at ApiBridgeHandler level.

Signed-off-by: clinique <gael@lhopital.org>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* Correcting issue by late loading of the capability.
* Handle MAXIMUM_USAGE_REACHED at ApiBridgeHandler level.

Signed-off-by: clinique <gael@lhopital.org>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* Correcting issue by late loading of the capability.
* Handle MAXIMUM_USAGE_REACHED at ApiBridgeHandler level.

Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Netatmo] Room-Thing offline after restart
3 participants