[homekit] allow configuring maxValue on VOCDensity #13508
Conversation
the default of 1000 is quite low in reality. tested and confirmed working with iOS 16 Signed-off-by: Cody Cutrer <cody@cutrer.us>
lolodomo
added
rebuild
|
@yfre : maybe you can make a first review |
lolodomo
added
the
enhancement
|
@ccutrer good idea. but why you have not added the support for step? |
| VOCDensityCharacteristic.DEFAULT_MIN_VALUE), | ||
| taggedItem.getConfigurationAsDouble(HomekitTaggedItem.MAX_VALUE, | ||
| VOCDensityCharacteristic.DEFAULT_MAX_VALUE), | ||
| 1.0, |
There was a problem hiding this comment.
please add support for step
taggedItem.getConfigurationAsDouble(HomekitTaggedItem.STEP,
VOCDensityCharacteristic.DEFAULT_STEP),
There was a problem hiding this comment.
sure. I didn't bother with step, because it's a read only attribute and AFAIK step should only affect UIs for writing things, to make it more helpful. but maybe it does respect it for something else, and I did min -- which one would think should always be zero -- so might as well. Though I could see setting min as something higher than zero if your sensor has a floor of how low it can detect. For example, my CO2 sensors have a floor of 400ppm.
Signed-off-by: Cody Cutrer <cody@cutrer.us>
* [homekit] allow configuring maxValue on VOCDensity the default of 1000 is quite low in reality. tested and confirmed working with iOS 16 * [homekit] allow step value to be configured for VOCDensity Signed-off-by: Cody Cutrer <cody@cutrer.us>
* [homekit] allow configuring maxValue on VOCDensity the default of 1000 is quite low in reality. tested and confirmed working with iOS 16 * [homekit] allow step value to be configured for VOCDensity Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* [homekit] allow configuring maxValue on VOCDensity the default of 1000 is quite low in reality. tested and confirmed working with iOS 16 * [homekit] allow step value to be configured for VOCDensity Signed-off-by: Cody Cutrer <cody@cutrer.us>
* [homekit] allow configuring maxValue on VOCDensity the default of 1000 is quite low in reality. tested and confirmed working with iOS 16 * [homekit] allow step value to be configured for VOCDensity Signed-off-by: Cody Cutrer <cody@cutrer.us>
* [homekit] allow configuring maxValue on VOCDensity the default of 1000 is quite low in reality. tested and confirmed working with iOS 16 * [homekit] allow step value to be configured for VOCDensity Signed-off-by: Cody Cutrer <cody@cutrer.us>
the default of 1000 is quite low in reality. tested and confirmed working with iOS 16