Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gce] File based items are not updated #13545

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Oct 13, 2022

The linkChannel and unlinkChannel methods are not called for file based items linked to channels.
This lead the binding to be unreactive to input channels.

Some code enhancement :
Check if channel is linked before sending updates.
Removed as much usage to @NonNullByDefault({}) and @nullable than possible.

Signed-off-by: clinique gael@lhopital.org

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique added the bug An unexpected problem or unintended behavior of an add-on label Oct 13, 2022
@clinique clinique self-assigned this Oct 13, 2022
Signed-off-by: clinique <gael@lhopital.org>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit bdbd5a1 into openhab:main Oct 15, 2022
@lolodomo lolodomo added this to the 3.4 milestone Oct 15, 2022
@clinique clinique deleted the gce_channel_update branch October 15, 2022 08:04
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [gce] Correcting non updated input channels

Signed-off-by: clinique <gael@lhopital.org>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [gce] Correcting non updated input channels

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
* [gce] Correcting non updated input channels

Signed-off-by: clinique <gael@lhopital.org>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [gce] Correcting non updated input channels

Signed-off-by: clinique <gael@lhopital.org>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [gce] Correcting non updated input channels

Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants