[miio] Correct channel ambientBrightness to type Dimmer for Yeelight Screen Light Bar

[michiii1337]

changed Datatype from "Number" to "Dimmer" at channel "ambientBrightness" same issue #9936 (but already fixed)

Signed-off-by: Michael Schmidts michael.schmidts@online.de

[marcelrv]

Hi @michiii1337
I recognize the issue with the dimmer vs number. I recall the problem is that I wanted to make it 2 ways, meaning that setting the dimming level in the app is also reflected in the dimming level in OH. As the device reports the level in whole number I believe it did not work well which is why I made it a number.

Can you test on your end and confirm that setting the dimming level via the app is properly reflected in OH.
If not, we prob need to add some calc to multiply/divided by 100... which is nowadays supported by the binding so I expect doable.

Also would be great to check some of the other yeelights if you have a chance for the same matter.
Lastly, once we have confirmed it all working right, please run the readme maker (in the test folder) to update the readme documentation accordingly.

[michiii1337]

I tested the dimming level via app and openhab. When the datatype is set to Dimmer, both in Xiaomi Home app and Openhab is the same/correct value. Unfortunately, I have no other Yeelights so I can only test this type.

[michiii1337]

the readme is now up to date. Hope I did everything right as this is my first pullreqest.

[marcelrv]

I think code wise it is fine.
There are some oddities wrt to the automatic generated readme but they are not caused by you and should be fixed by translating the relevant values and than it fixes itself

There is a commit signoff issue with 2 of the commits. You can try to 'squash' in eclipse and update the the commit comment to include the signoff-by (like you did in your last commit)
Or if whoever is merging this agrees you can just click accept DCO and it will be fine as well. (I don't have rights to merge the PR)

[jlaur]

Thanks! There seem to be some character set issues that would need to be resolved, and also the DCO check must pass.

[michiii1337]

I fixed the characters in the readme. How can i fix the DCO? I can not edit the 3 commits without my sign.

[marcelrv]

You can try to 'squash' in eclipse and update the the commit comment to include the signoff-by (like you did in your last commit)

[michiii1337]

i tried already to squash the commits but i received a error message: "Unable to squash. Squashing replays all commits up to the last one required for the squash. A merge commit cannot exist among those commits"

[jlaur]

I fixed the characters in the readme. How can i fix the DCO? I can not edit the 3 commits without my sign.

You could try to click "Details" in the DCO check line and follow the steps described, or you could have a look at this:
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

[michiii1337]

i followed the instructions under "Details" and now the DCO failed again... is it easier to start from zero and make an new PR?

[marcelrv]

Maybe what's working is to do first a rebase, than I think it will allow you to do the squash.
Making a new branch from current and copy the few changes is indeed also a way

[michiii1337]

i have done a rebase and i got the same error message when i try to squash

[michiii1337]

ok, now i have done a rebase. before that i seem to have done only a merge. Sorry for the many questions and problem in the PR I am still learning. Hope now the commits can be merged.

[jlaur]

ok, now i have done a rebase

I'm sorry, but that did no go well, as there are now changes from other bindings included. Perhaps at this point it would be best to:

• Backup your changes files.
• Delete your branch locally.
• Create a new branch from main with the same name as the deleted branch.
• Apply your changes again (by copying the changed files).
• Force push the new branch.

[michiii1337]

my branch is "main". if i delete this branch how should i create new branch from main?

[jlaur]

my branch is "main". if i delete this branch how should i create new branch from main?

Ah, sorry, I didn't see that. Assuming your fork is new and you don't have other branches to keep, for this PR I would adapt the plan to:

• Backup your repository.
• Delete your fork.
• Create a new fork.
• Apply your changes again (by copying the changed files).
• Commit again to main while making sure signoff is correct.
• Force push main.

I don't know if it will work, but it might be worth a shot. After that, I would then suggest to recreate the fork again, and make sure you don't commit anything to main, as it will most likely cause problems for you. Instead you should create a new branch, and use this when creating a PR.

[Hilbrand]

It looks like only 1 commit is wrong. You can also just remove that one commit. Use git rebase -i HEAD~6. This will open an editor with the list of commits. Replace pick with d on the commit you want to remove. Than save the file. After that do a push force.

[michiii1337]

Thanks @Hilbrand and @jlaur removed the wrong commit.

[jlaur]

Thank you!