Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Console command to show all devices/modules ids #13555

Merged
merged 3 commits into from
Oct 19, 2022
Merged

[netatmo] Console command to show all devices/modules ids #13555

merged 3 commits into from
Oct 19, 2022

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Oct 16, 2022 •
edited
Loading

Fix #13091

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo requested a review from clinique as a code owner October 16, 2022 09:17
@lolodomo lolodomo force-pushed the netatmo_fix_null_check_errors branch from aa11c54 to a3aca39 Compare October 16, 2022 19:54
@lolodomo lolodomo changed the title [netatmo] Fix null check errors in Eclipse [netatmo] Console command to show all devices/modules ids Oct 16, 2022
@lolodomo
Copy link
Contributor Author

lolodomo commented Oct 16, 2022 •
edited
Loading

@clinique : I extended the original PR to cover another need. So your approval is no more valid until your make a new review.

@lolodomo
[netatmo] Console command to show all devices/modules ids
2c03ce8 
Fix openhab#13091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the netatmo_fix_null_check_errors branch from a3aca39 to 2c03ce8 Compare October 16, 2022 20:14
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Oct 16, 2022
@lolodomo
Ypdated README
336d409 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

lolodomo commented Oct 18, 2022 •
edited
Loading

@jlaur : could you please finish the review?

@jlaur
Copy link
Contributor

jlaur commented Oct 18, 2022

@jlaur : could you please finish the review?

Sorry, didn't really start a review, just posted a single comment. I'm on holiday until Friday, but will try to have a look later in the evening or possibly tomorrow.

jlaur
jlaur reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is indeed a cool feature. I didn't know this was possible, I'm sure I can use this for other similar use cases. :-) Only a single question. Unfortunately I'm away from my development PC, but if you could provide a JAR, I would still be able to give it a quick test run. Otherwise I can approve as-is.

...atmo/src/main/java/org/openhab/binding/netatmo/internal/console/NetatmoCommandExtension.java Show resolved Hide resolved
@jlaur jlaur mentioned this pull request Oct 18, 2022
Merged
@lolodomo
Change command parameter from ids to showIds
a7096ff 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

Unfortunately I'm away from my development PC, but if you could provide a JAR, I would still be able to give it a quick test run

Here is a jar for testing
org.openhab.binding.netatmo-3.4.0-SNAPSHOT.zip

jlaur
jlaur approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jlaur
Copy link
Contributor

jlaur commented Oct 19, 2022

Here is a jar for testing
org.openhab.binding.netatmo-3.4.0-SNAPSHOT.zip

Thanks! I tested it and the console command looks good.

@jlaur jlaur merged commit 77013bc into openhab:main Oct 19, 2022
@jlaur jlaur added this to the 3.4 milestone Oct 19, 2022
@lolodomo lolodomo deleted the netatmo_fix_null_check_errors branch October 19, 2022 10:39
This was referenced Oct 24, 2022
Closed
Closed
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@lolodomo @andan67
[netatmo] Console command to show all devices/modules ids (openhab#13555
0b806b1 
)

* [netatmo] Console command to show all devices/modules ids

Fix openhab#13091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@lolodomo @andrasU
[netatmo] Console command to show all devices/modules ids (openhab#13555
b90f128 
)

* [netatmo] Console command to show all devices/modules ids

Fix openhab#13091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@lolodomo @borazslo
[netatmo] Console command to show all devices/modules ids (openhab#13555
e34f159 
)

* [netatmo] Console command to show all devices/modules ids

Fix openhab#13091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@lolodomo @psmedley
[netatmo] Console command to show all devices/modules ids (openhab#13555
e516a4b 
)

* [netatmo] Console command to show all devices/modules ids

Fix openhab#13091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lolodomo @nemerdaud
[netatmo] Console command to show all devices/modules ids (openhab#13555
f2d55bc 
)

* [netatmo] Console command to show all devices/modules ids

Fix openhab#13091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@clinique clinique clinique approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

[Netatmo] Getting ID:s for Netatmo modules.
3 participants
@lolodomo @jlaur @clinique