Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lgwebos] Console command completion #13590

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Oct 23, 2022

Signed-off-by: Laurent Garnier lg.hc@free.fr

Depends on openhab/openhab-core#3111

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Oct 23, 2022
@lolodomo lolodomo requested a review from sprehn as a code owner October 23, 2022 16:40
@lolodomo
Copy link
Contributor Author

Partial in the context means that it is not yet possible to complete the thing UID required as parameter.
A change must be implemented first in the core framework.

@lolodomo
Copy link
Contributor Author

In fact, everything is there in core framework to retrieve all things. I am going to add completion on the thing UID.

@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label Oct 24, 2022
@lolodomo lolodomo force-pushed the lgwebos_console_completion branch from 587e4f2 to ed1d629 Compare October 24, 2022 11:10
@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label Oct 24, 2022
@lolodomo
Copy link
Contributor Author

Full parameters completion is now implemented. PR is ready for review.

@lolodomo lolodomo changed the title [lgwebos] Console command completion (partial) [lgwebos] Console command completion Oct 24, 2022
@lolodomo lolodomo force-pushed the lgwebos_console_completion branch 2 times, most recently from 11df0f1 to 1bad3d2 Compare October 24, 2022 18:42
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the lgwebos_console_completion branch from 1bad3d2 to 0c67927 Compare October 25, 2022 06:23
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jlaur jlaur merged commit 2c78c3b into openhab:main Oct 25, 2022
@jlaur jlaur added this to the 3.4 milestone Oct 25, 2022
@lolodomo lolodomo deleted the lgwebos_console_completion branch October 25, 2022 08:13
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants