Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hue] Console command completion #13597

Merged
merged 1 commit into from
Oct 25, 2022
Merged

[hue] Console command completion #13597

merged 1 commit into from
Oct 25, 2022

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Oct 24, 2022 •
edited by jlaur
Loading

Signed-off-by: Laurent Garnier lg.hc@free.fr

Depends on openhab/openhab-core#3111

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Oct 24, 2022
@lolodomo lolodomo requested a review from cweitkamp as a code owner October 24, 2022 16:59
@lolodomo lolodomo force-pushed the hue_console_completion branch 5 times, most recently from 1197244 to 8407504 Compare October 24, 2022 18:59
@lolodomo
[hue] Console command completion
8d403cc 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the hue_console_completion branch from 8407504 to 8d403cc Compare October 24, 2022 19:07
jlaur
jlaur approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jlaur jlaur merged commit 6a76a59 into openhab:main Oct 25, 2022
@jlaur jlaur added this to the 3.4 milestone Oct 25, 2022
@lolodomo lolodomo deleted the hue_console_completion branch October 25, 2022 08:12
@andrewfg
Copy link
Contributor

@lolodomo many thanks for this. It will definitely be needed in #13570 because all CLIP 2 resources are all 32 character UIDs. Therefore I already extended your class to support CLIP 2 hubs. See screenshot below..

image

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@lolodomo @andan67
[hue] Console command completion (openhab#13597)
e79d3cc 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@lolodomo @andrasU
[hue] Console command completion (openhab#13597)
cbb85eb 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
@andrewfg andrewfg mentioned this pull request Dec 25, 2022
Merged
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@lolodomo @borazslo
[hue] Console command completion (openhab#13597)
bc4852f 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@lolodomo @psmedley
[hue] Console command completion (openhab#13597)
4267b23 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lolodomo @nemerdaud
[hue] Console command completion (openhab#13597)
b555f15 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @andrewfg @jlaur