Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jdbc] Upgrade MariaDB JDBC driver to 3.0.8 #13659

Merged
merged 1 commit into from
Nov 9, 2022
Merged

[jdbc] Upgrade MariaDB JDBC driver to 3.0.8 #13659

merged 1 commit into from
Nov 9, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Nov 5, 2022 •
edited
Loading

See https://mariadb.com/kb/en/mariadb-connector-j-release-notes/

Test

JAR: org.openhab.persistence.jdbc-3.4.0-SNAPSHOT.jar

To test, place this file in the addons directory and rename it to mariadb-java-client.jar:
https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/3.0.8/mariadb-java-client-3.0.8.jar

Testing this is quite important as the previous version was more than six years old.

Related forum thread: https://community.openhab.org/t/jdbc-persistence-with-tableuserealitemnames-and-tableiddigitcount-0/40552/18

@jlaur
Upgrade MariaDB connector to 3.0.8
571fe7b 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/jdbc-persistence-with-tableuserealitemnames-and-tableiddigitcount-0/40552/19

@wborn wborn added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Nov 5, 2022
@cweitkamp
Copy link
Contributor

I am running this new version for two days now without any problem. From my side it looks good.

@jlaur jlaur marked this pull request as ready for review November 9, 2022 17:51
@jlaur jlaur requested a review from a team as a code owner November 9, 2022 17:51
@jlaur jlaur removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Nov 9, 2022
@wborn wborn merged commit 64791b3 into openhab:main Nov 9, 2022
@wborn wborn added this to the 3.4 milestone Nov 9, 2022
@cweitkamp
Copy link
Contributor

@kaikreuzer May I ask you to upload the linked mariadb-java-client.jar (https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/3.0.8/mariadb-java-client-3.0.8.jar) to jfrog for this upgrade to work? Thank you.

@jlaur
Copy link
Contributor Author

jlaur commented Nov 11, 2022

@kaikreuzer May I ask you to upload the linked mariadb-java-client.jar (https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/3.0.8/mariadb-java-client-3.0.8.jar) to jfrog for this upgrade to work? Thank you.

Thanks for remembering, was going to ask the same yesterday, but momentarily forgot.

@wborn
Copy link
Member

wborn commented Nov 11, 2022

I also always forget this part. 😉

@jlaur jlaur deleted the jdbc-mariadb-upgrade branch November 11, 2022 15:29
@kaikreuzer
Copy link
Member

@kaikreuzer May I ask you to upload the linked mariadb-java-client.jar

Done!

@jlaur jlaur mentioned this pull request Nov 24, 2022
Open
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@jlaur @borazslo
[jdbc] Upgrade MariaDB connector to 3.0.8 (openhab#13659)
cf9ea44 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@jlaur @psmedley
[jdbc] Upgrade MariaDB connector to 3.0.8 (openhab#13659)
1633777 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@jlaur @nemerdaud
[jdbc] Upgrade MariaDB connector to 3.0.8 (openhab#13659)
d4c19d2 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jlaur @openhab-bot @cweitkamp @wborn @kaikreuzer