Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[avmfritz] Decode alarm state for blinds #13672

Merged
merged 4 commits into from
Nov 11, 2022

Conversation

quidam
Copy link
Contributor

@quidam quidam commented Nov 7, 2022

This PR adds the decoding of the alert state bitmap of blinds into separate channels for each alarm reason (presently obstruction and overheating).

There is an enhancement request for this feature in #13663.

@quidam quidam requested a review from cweitkamp as a code owner November 7, 2022 12:06
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

@lolodomo
Copy link
Contributor

lolodomo commented Nov 9, 2022

Please also sign off properly your PR.

Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
@quidam quidam force-pushed the 13663-decode-alarm-state-for-blinds branch from 51e6ef0 to 49f5b60 Compare November 9, 2022 14:28
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Nov 10, 2022
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
@quidam quidam requested a review from lolodomo November 10, 2022 08:08
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 8c7d774 into openhab:main Nov 11, 2022
@lolodomo lolodomo added this to the 3.4 milestone Nov 11, 2022
@quidam quidam deleted the 13663-decode-alarm-state-for-blinds branch November 12, 2022 06:52
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
* [avmfritz] Decode alarm state for blinds
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [avmfritz] Decode alarm state for blinds
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [avmfritz] Decode alarm state for blinds
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants