-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[avmfritz] Decode alarm state for blinds #13672
[avmfritz] Decode alarm state for blinds #13672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/i18n/avmfritz_de.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
Please also sign off properly your PR. |
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
51e6ef0
to
49f5b60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final review
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/i18n/avmfritz.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
...tz/src/main/java/org/openhab/binding/avmfritz/internal/handler/AVMFritzBaseThingHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
* [avmfritz] Decode alarm state for blinds Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
* [avmfritz] Decode alarm state for blinds Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
* [avmfritz] Decode alarm state for blinds Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
This PR adds the decoding of the alert state bitmap of blinds into separate channels for each alarm reason (presently obstruction and overheating).
There is an enhancement request for this feature in #13663.