Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boschshc] Support smart light bulbs #13725

Merged
merged 3 commits into from
Nov 20, 2022

Conversation

david-pace
Copy link
Member

  • add thing type definition for smart bulbs using system channels
  • add constants for thing type and channels
  • implement and register handler
  • implement binary switch service (to switch on/off)
  • implement multi-level switch service (allows to get/set brightness from 0-100%)
  • implement service to get and set colors
  • add unit tests for handler and state classes

Signed-off-by: David Pace dev@davidpace.de

@david-pace david-pace linked an issue Nov 15, 2022 that may be closed by this pull request
@david-pace david-pace marked this pull request as draft November 15, 2022 20:38
* add thing type definition for smart bulbs using system channels
* add constants for thing type and channels
* implement and register handler
* implement binary switch service (to switch on/off)
* implement multi-level switch service (allows to get/set brightness
from 0-100%)
* implement service to get and set colors
* add unit tests for handler and state classes
- update documentation

Signed-off-by: David Pace <dev@davidpace.de>
@david-pace david-pace force-pushed the 13707-smart-bulb-support branch from 50bb9d6 to 17d0a1a Compare November 15, 2022 21:13
@david-pace david-pace marked this pull request as ready for review November 15, 2022 21:13
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Nov 16, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice addition. It looks good! Please regenerate the i18n properties file.

@david-pace david-pace marked this pull request as draft November 19, 2022 21:46
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: David Pace <dev@davidpace.de>
@david-pace david-pace force-pushed the 13707-smart-bulb-support branch from 3e87a7b to 32e4651 Compare November 19, 2022 22:06
@david-pace
Copy link
Member Author

Please regenerate the i18n properties file.

Thanks for the hint, I was not aware of this file yet. I ran mvn i18n:generate-default-translations and hope this is sufficient.

@david-pace david-pace marked this pull request as ready for review November 19, 2022 22:15
@david-pace david-pace requested a review from jlaur November 19, 2022 22:15
Signed-off-by: David Pace <dev@davidpace.de>
@david-pace david-pace force-pushed the 13707-smart-bulb-support branch from 32e4651 to a4903ac Compare November 19, 2022 22:28
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 1251873 into openhab:main Nov 20, 2022
@jlaur jlaur added this to the 3.4 milestone Nov 20, 2022
@david-pace david-pace deleted the 13707-smart-bulb-support branch November 20, 2022 22:04
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Dec 24, 2022
* [boschshc] Support smart light bulbs (openhab#13707)

* add thing type definition for smart bulbs using system channels
* add constants for thing type and channels
* implement and register handler
* implement binary switch service (to switch on/off)
* implement multi-level switch service (allows to get/set brightness
from 0-100%)
* implement service to get and set colors
* add unit tests for handler and state classes
- update documentation

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
* [boschshc] Support smart light bulbs (openhab#13707)

* add thing type definition for smart bulbs using system channels
* add constants for thing type and channels
* implement and register handler
* implement binary switch service (to switch on/off)
* implement multi-level switch service (allows to get/set brightness
from 0-100%)
* implement service to get and set colors
* add unit tests for handler and state classes
- update documentation

Signed-off-by: David Pace <dev@davidpace.de>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [boschshc] Support smart light bulbs (openhab#13707)

* add thing type definition for smart bulbs using system channels
* add constants for thing type and channels
* implement and register handler
* implement binary switch service (to switch on/off)
* implement multi-level switch service (allows to get/set brightness
from 0-100%)
* implement service to get and set colors
* add unit tests for handler and state classes
- update documentation

Signed-off-by: David Pace <dev@davidpace.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [boschshc] Support smart light bulbs (openhab#13707)

* add thing type definition for smart bulbs using system channels
* add constants for thing type and channels
* implement and register handler
* implement binary switch service (to switch on/off)
* implement multi-level switch service (allows to get/set brightness
from 0-100%)
* implement service to get and set colors
* add unit tests for handler and state classes
- update documentation

Signed-off-by: David Pace <dev@davidpace.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 6, 2024
* [boschshc] Support smart light bulbs (openhab#13707)

* add thing type definition for smart bulbs using system channels
* add constants for thing type and channels
* implement and register handler
* implement binary switch service (to switch on/off)
* implement multi-level switch service (allows to get/set brightness
from 0-100%)
* implement service to get and set colors
* add unit tests for handler and state classes
- update documentation

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[boschshc] Support smart light bulbs
3 participants