-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boschshc] Support smart light bulbs #13725
Conversation
* add thing type definition for smart bulbs using system channels * add constants for thing type and channels * implement and register handler * implement binary switch service (to switch on/off) * implement multi-level switch service (allows to get/set brightness from 0-100%) * implement service to get and set colors * add unit tests for handler and state classes - update documentation Signed-off-by: David Pace <dev@davidpace.de>
50bb9d6
to
17d0a1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice addition. It looks good! Please regenerate the i18n properties file.
...rg/openhab/binding/boschshc/internal/services/binaryswitch/dto/BinarySwitchServiceState.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: David Pace <dev@davidpace.de>
3e87a7b
to
32e4651
Compare
Thanks for the hint, I was not aware of this file yet. I ran |
Signed-off-by: David Pace <dev@davidpace.de>
32e4651
to
a4903ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [boschshc] Support smart light bulbs (openhab#13707) * add thing type definition for smart bulbs using system channels * add constants for thing type and channels * implement and register handler * implement binary switch service (to switch on/off) * implement multi-level switch service (allows to get/set brightness from 0-100%) * implement service to get and set colors * add unit tests for handler and state classes - update documentation Signed-off-by: David Pace <dev@davidpace.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* [boschshc] Support smart light bulbs (openhab#13707) * add thing type definition for smart bulbs using system channels * add constants for thing type and channels * implement and register handler * implement binary switch service (to switch on/off) * implement multi-level switch service (allows to get/set brightness from 0-100%) * implement service to get and set colors * add unit tests for handler and state classes - update documentation Signed-off-by: David Pace <dev@davidpace.de>
* [boschshc] Support smart light bulbs (openhab#13707) * add thing type definition for smart bulbs using system channels * add constants for thing type and channels * implement and register handler * implement binary switch service (to switch on/off) * implement multi-level switch service (allows to get/set brightness from 0-100%) * implement service to get and set colors * add unit tests for handler and state classes - update documentation Signed-off-by: David Pace <dev@davidpace.de>
* [boschshc] Support smart light bulbs (openhab#13707) * add thing type definition for smart bulbs using system channels * add constants for thing type and channels * implement and register handler * implement binary switch service (to switch on/off) * implement multi-level switch service (allows to get/set brightness from 0-100%) * implement service to get and set colors * add unit tests for handler and state classes - update documentation Signed-off-by: David Pace <dev@davidpace.de>
* [boschshc] Support smart light bulbs (openhab#13707) * add thing type definition for smart bulbs using system channels * add constants for thing type and channels * implement and register handler * implement binary switch service (to switch on/off) * implement multi-level switch service (allows to get/set brightness from 0-100%) * implement service to get and set colors * add unit tests for handler and state classes - update documentation Signed-off-by: David Pace <dev@davidpace.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Signed-off-by: David Pace dev@davidpace.de