-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homekit] simplify settings page, resize doc images #13741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugen <eugen@relotrust.com>
yfre
force-pushed
the
config_clean_up
branch
from
November 18, 2022 17:29
29b70a0
to
c81d122
Compare
lolodomo
requested changes
Nov 19, 2022
bundles/org.openhab.io.homekit/src/main/resources/OH-INF/config/config.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.io.homekit/src/main/resources/OH-INF/config/config.xml
Show resolved
Hide resolved
lolodomo
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Nov 20, 2022
Signed-off-by: Eugen <eugen@relotrust.com>
lolodomo
approved these changes
Nov 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Dec 24, 2022
* simplify config, resize images Signed-off-by: Eugen <eugen@relotrust.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
* simplify config, resize images Signed-off-by: Eugen <eugen@relotrust.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* simplify config, resize images Signed-off-by: Eugen <eugen@relotrust.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* simplify config, resize images Signed-off-by: Eugen <eugen@relotrust.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 6, 2024
* simplify config, resize images Signed-off-by: Eugen <eugen@relotrust.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases homekit binding works well with default settings, some of them are automatically derived from openHAB setting. this PR simplify the homekit setting page by marking some settings as advanced (hidden by default)
i have also change the size of some image in the documentation, they were too big.
Signed-off-by: Eugen Freiter freiter@gmx.de