Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] simplify settings page, resize doc images #13741

Merged
merged 2 commits into from
Nov 20, 2022

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Nov 18, 2022

In many cases homekit binding works well with default settings, some of them are automatically derived from openHAB setting. this PR simplify the homekit setting page by marking some settings as advanced (hidden by default)
i have also change the size of some image in the documentation, they were too big.

Signed-off-by: Eugen Freiter freiter@gmx.de

@yfre yfre requested a review from andylintner as a code owner November 18, 2022 17:29
Signed-off-by: Eugen <eugen@relotrust.com>
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Nov 20, 2022
Signed-off-by: Eugen <eugen@relotrust.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 54e934b into openhab:main Nov 20, 2022
@lolodomo lolodomo added this to the 3.4 milestone Nov 20, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Dec 24, 2022
* simplify config, resize images

Signed-off-by: Eugen <eugen@relotrust.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
* simplify config, resize images

Signed-off-by: Eugen <eugen@relotrust.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* simplify config, resize images

Signed-off-by: Eugen <eugen@relotrust.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* simplify config, resize images

Signed-off-by: Eugen <eugen@relotrust.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 6, 2024
* simplify config, resize images

Signed-off-by: Eugen <eugen@relotrust.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants