[Nanoleaf] Add new channel: State #13746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows an image of the state of the panels with color. Also makes the layout slightly prettier. This is less functional than the layout, and more eyecandy. Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
|
|
stefan-hoehn
requested changes
Nov 20, 2022
There was a problem hiding this comment.
That review was a huge one - I hope the next ones are going to be smaller ;-)
...but the outcome is worth taking the time.
Mainly it looks good to me: there only minor comments from me.
@jlaur after @austvik has done the small amendments I recommend you merge it (if you don't have the time to fully review it).
...ain/java/org/openhab/binding/nanoleaf/internal/layout/shape/BarycentricTriangleGradient.java
Show resolved
Hide resolved
...ain/java/org/openhab/binding/nanoleaf/internal/layout/shape/BarycentricTriangleGradient.java
Show resolved
Hide resolved
...inding.nanoleaf/src/main/java/org/openhab/binding/nanoleaf/internal/layout/shape/Square.java
Outdated
Show resolved
Hide resolved
- Example in README - Renames to make the Panels/Shapes easier to understand Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
...binding.nanoleaf/src/main/java/org/openhab/binding/nanoleaf/internal/layout/shape/Shape.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
|
Thanks, Stefan. Reworded the comment. |
jlaur
requested changes
Dec 1, 2022
Split README in lines to make easier changes later. Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
jlaur
reviewed
Dec 2, 2022
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
changed the title
morph166955
pushed a commit
to morph166955/openhab-addons
that referenced
this pull request
Dec 18, 2022
* [Nanoleaf] New Channel: State Shows an image of the state of the panels with color. Also makes the layout slightly prettier. This is less functional than the layout, and more eyecandy. Signed-off-by: Jørgen Austvik <jaustvik@acm.org> Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Dec 24, 2022
* [Nanoleaf] New Channel: State Shows an image of the state of the panels with color. Also makes the layout slightly prettier. This is less functional than the layout, and more eyecandy. Signed-off-by: Jørgen Austvik <jaustvik@acm.org> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
* [Nanoleaf] New Channel: State Shows an image of the state of the panels with color. Also makes the layout slightly prettier. This is less functional than the layout, and more eyecandy. Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [Nanoleaf] New Channel: State Shows an image of the state of the panels with color. Also makes the layout slightly prettier. This is less functional than the layout, and more eyecandy. Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* [Nanoleaf] New Channel: State Shows an image of the state of the panels with color. Also makes the layout slightly prettier. This is less functional than the layout, and more eyecandy. Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 6, 2024
* [Nanoleaf] New Channel: State Shows an image of the state of the panels with color. Also makes the layout slightly prettier. This is less functional than the layout, and more eyecandy. Signed-off-by: Jørgen Austvik <jaustvik@acm.org> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition that shows an image of the state of the panels with color.
Also makes the layout slightly prettier. This is less functional than the layout, and more eye-candy.
Idea by Stefan Hoehn from #13552
Signed-off-by: Jørgen Austvik jaustvik@acm.org