[ipcamera] Instar API updates for new 2k+ range #13805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah
added
enhancement
Skinah
changed the title
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah
changed the title
lolodomo
reviewed
Dec 2, 2022
...nhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/InstarHandler.java
Outdated
Show resolved
Hide resolved
...nhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/InstarHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
|
All review comments have been addressed. |
lolodomo
requested changes
Dec 3, 2022
...nhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/InstarHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Skinner <matt@pcmus.com>
morph166955
pushed a commit
to morph166955/openhab-addons
that referenced
this pull request
Dec 18, 2022
* Instar updates * Detect which API to use from reply. * Add handling of REFRESH to instar. Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Dec 24, 2022
* Instar updates * Detect which API to use from reply. * Add handling of REFRESH to instar. Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
* Instar updates * Detect which API to use from reply. * Add handling of REFRESH to instar. Signed-off-by: Matthew Skinner <matt@pcmus.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Instar updates * Detect which API to use from reply. * Add handling of REFRESH to instar. Signed-off-by: Matthew Skinner <matt@pcmus.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Instar updates * Detect which API to use from reply. * Add handling of REFRESH to instar. Signed-off-by: Matthew Skinner <matt@pcmus.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 6, 2024
* Instar updates * Detect which API to use from reply. * Add handling of REFRESH to instar. Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 1 bug fix in the ONVIF connecting code that was causing issues with Instar and possibly other brands as well. The Host http header was blank.
The rest of the changes are to provide support for a newer 2k range of cameras that have a different API implemented in them.
Jar can be RIGHT HAND CLICKED and downloaded from:
https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.ipcamera/3.4.0-SNAPSHOT/org.openhab.binding.ipcamera-3.4.0-SNAPSHOT.jar
Signed-off-by: Matthew Skinner matt@pcmus.com