Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos a/an #13812

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Typos a/an #13812

merged 1 commit into from
Dec 1, 2022

Conversation

dilyanpalauzov
Copy link
Contributor

No description provided.

@fwolter
Copy link
Member

fwolter commented Dec 1, 2022

Thank you for this PR! Catching also things like "a {@link AsynchronousSocketChannel}" looks like a bit more sophisticated script. I guess you didn't do that by hand...?

@dilyanpalauzov
Copy link
Contributor Author

I found the places with git grep and then changed the files by hand.

fwolter
fwolter approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good work!

@fwolter
Copy link
Member

fwolter commented Dec 1, 2022

There's a formatting error due to a line, which became one character longer. Can you run mvn spotless:apply?

@fwolter fwolter merged commit 78534e8 into openhab:main Dec 1, 2022
@fwolter fwolter added this to the 3.4 milestone Dec 1, 2022
@dilyanpalauzov dilyanpalauzov deleted the typos_a_an branch December 1, 2022 14:58
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Dec 24, 2022
@dilyanpalauzov @andrasU
Typos a/an (openhab#13812)
48c7ceb 
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@dilyanpalauzov @borazslo
Typos a/an (openhab#13812)
2a78a85
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@dilyanpalauzov @psmedley
Typos a/an (openhab#13812)
a8554b8
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@dilyanpalauzov @nemerdaud
Typos a/an (openhab#13812)
2736d35
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 6, 2024
@dilyanpalauzov @andrasU
Typos a/an (openhab#13812)
cf2f16f 
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@fwolter fwolter fwolter approved these changes

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@jochen314 jochen314 Awaiting requested review from jochen314 jochen314 is a code owner

@lujop lujop Awaiting requested review from lujop lujop is a code owner

@tmrobert8 tmrobert8 Awaiting requested review from tmrobert8

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

@zarusz zarusz Awaiting requested review from zarusz zarusz is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@svilenvul svilenvul Awaiting requested review from svilenvul

@msteigenberger msteigenberger Awaiting requested review from msteigenberger msteigenberger is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

@peuter peuter Awaiting requested review from peuter peuter is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@raepple raepple Awaiting requested review from raepple

@stefan-hoehn stefan-hoehn Awaiting requested review from stefan-hoehn stefan-hoehn is a code owner

@antroids antroids Awaiting requested review from antroids antroids is a code owner

@bobadair bobadair Awaiting requested review from bobadair bobadair is a code owner

@Markinus Markinus Awaiting requested review from Markinus Markinus is a code owner

@ollie-dev ollie-dev Awaiting requested review from ollie-dev

@bruestel bruestel Awaiting requested review from bruestel bruestel is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@soenkekueper soenkekueper Awaiting requested review from soenkekueper soenkekueper is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister is a code owner

@blafois blafois Awaiting requested review from blafois blafois is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

@dominicdesu dominicdesu Awaiting requested review from dominicdesu dominicdesu is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dilyanpalauzov @fwolter @wborn