[neohub] Recover faster if NeoHub produces empty responses #13889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
changed the title
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
changed the title
andrewfg
changed the title
|
It looks to me more an enhancement than a bug resolution? |
andrewfg
added
enhancement
|
^ |
andrewfg
added
rebuild
|
@lolodomo .. but even if it is 'only' an enhancement it would be nice if it could get into RC1 |
lolodomo
added
rebuild
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
…3889) * [neohub] resolve issue openhab#13829 * [neohub] harmonise exceptions and logging * [neohub] improve field name, and log messages Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…3889) * [neohub] resolve issue openhab#13829 * [neohub] harmonise exceptions and logging * [neohub] improve field name, and log messages Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
…3889) * [neohub] resolve issue openhab#13829 * [neohub] harmonise exceptions and logging * [neohub] improve field name, and log messages Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13829
Issue
As mentioned in #13829 the bridge sporadically goes offline (due to 'Null or invalid response'), and it remains offline until the next polling cycle produces a valid response, whereupon it goes online again.
Apparently the reason for this is that there is a bug in the NeoHub, whereby it does indeed sporadically produce empty response packages!!
Note: the NeoHub does produce a response so it is technically online, however the response is empty, so the binding has no data to update the channels.
The issue is being discussed on the HeatMiser Developer portal, and it seems the solution (work around) is to simply repeat the command immediately so the NeoHub produces a non empty response.
Furthermore, during testing of this PR I became aware of some inconsistencies between the various methods of the
NeoHubSocketresp.NeoHubWebSocketclasses..NeoHubExceptionresp.IOExceptionwere used inconsistently between the two classes.Solution
This PR makes the following changes..
NeoHubException/IOExceptionis now consistent overNeoHubSocket/NeoHubWebSocket.NeoHubSocket/NeoHubWebSocket.NeoHubSocket/NeoHubWebSocket.Signed-off-by: Andrew Fiddian-Green software@whitebear.ch