[ipcamera] Add a check to see if FFmpeg is frozen for mjpeg creation #13896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <matt@pcmus.com>
lolodomo
requested changes
Dec 10, 2022
...ng.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/handler/IpCameraHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Skinner <matt@pcmus.com>
morph166955
pushed a commit
to morph166955/openhab-addons
that referenced
this pull request
Dec 18, 2022
…penhab#13896) * check if ffmpegMjpeg is frozen Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/ipcamera-new-ip-camera-binding/42771/2821 |
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Dec 24, 2022
…penhab#13896) * check if ffmpegMjpeg is frozen Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
…penhab#13896) * check if ffmpegMjpeg is frozen Signed-off-by: Matthew Skinner <matt@pcmus.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…penhab#13896) * check if ffmpegMjpeg is frozen Signed-off-by: Matthew Skinner <matt@pcmus.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…penhab#13896) * check if ffmpegMjpeg is frozen Signed-off-by: Matthew Skinner <matt@pcmus.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 6, 2024
…penhab#13896) * check if ffmpegMjpeg is frozen Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a user report that a Unifi protect camera does not get detected as OFFLINE by the binding as the base station/hub/bridge stays online whilst the camera itself does a reboot. FFmpeg hangs if the stream stops midway so this fix will check if the thread is still working when it is needed. Also hard coded URLS in for newer range Instar cameras.
Reported via forum here:
https://community.openhab.org/t/ipcamera-streams-not-automatically-updating-cached/141223/15
Jar can be RIGHT HAND CLICKED and
save link asto get around the jfrog login from:https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.ipcamera/3.4.0-SNAPSHOT/org.openhab.binding.ipcamera-3.4.0-SNAPSHOT.jar
Signed-off-by: Matthew Skinner matt@pcmus.com