[jsscripting] Upgrade openhab-js & Remove SharedCache #13908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades the included openhab-js version to 3.1.0, which uses the new caches from core (introduced in openhab/openhab-core#2887) and provides many doc improvements. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Removes the SharedCache from the addon because this functionality is now provided by core (see openhab/openhab-core#2887). Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added
the
enhancement
wborn
requested changes
Dec 11, 2022
There was a problem hiding this comment.
It seems to break the build:
Error: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.1:npx (npx webpack) on project org.openhab.automation.jsscripting: Failed to run task: 'npx webpack -c ./node_modules/openhab/webpack.config.js --entry ./node_modules/openhab/ -o ./dist' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 2 (Exit value: 2) -> [Help 1]
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
I see the problem, I'll fix it later. |
The addon build failed due to webpack exiting with 1 because of a missing webpack configuration for „@runtime/cache“. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@wborn The build is now working. I‘ve also had a look at the classed in the |
wborn
approved these changes
Dec 11, 2022
morph166955
pushed a commit
to morph166955/openhab-addons
that referenced
this pull request
Dec 18, 2022
Upgrades the included openhab-js version to 3.1.0, which uses the new caches from core (introduced in openhab/openhab-core#2887) and provides many doc improvements. Removes the SharedCache from the addon because this functionality is now provided by core (see openhab/openhab-core#2887). Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Dec 24, 2022
Upgrades the included openhab-js version to 3.1.0, which uses the new caches from core (introduced in openhab/openhab-core#2887) and provides many doc improvements. Removes the SharedCache from the addon because this functionality is now provided by core (see openhab/openhab-core#2887). Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
Upgrades the included openhab-js version to 3.1.0, which uses the new caches from core (introduced in openhab/openhab-core#2887) and provides many doc improvements. Removes the SharedCache from the addon because this functionality is now provided by core (see openhab/openhab-core#2887). Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Upgrades the included openhab-js version to 3.1.0, which uses the new caches from core (introduced in openhab/openhab-core#2887) and provides many doc improvements. Removes the SharedCache from the addon because this functionality is now provided by core (see openhab/openhab-core#2887). Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
Upgrades the included openhab-js version to 3.1.0, which uses the new caches from core (introduced in openhab/openhab-core#2887) and provides many doc improvements. Removes the SharedCache from the addon because this functionality is now provided by core (see openhab/openhab-core#2887). Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 6, 2024
Upgrades the included openhab-js version to 3.1.0, which uses the new caches from core (introduced in openhab/openhab-core#2887) and provides many doc improvements. Removes the SharedCache from the addon because this functionality is now provided by core (see openhab/openhab-core#2887). Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the included openhab-js version to 3.1.0, which uses the new caches from core instead of the addon provided one and brings many doc improvements.
The
SharedCacheis therefore removed as it is superseded by the caches added to core in openhab/openhab-core#2887.@jlaur Ping.
@wborn FYI: We can now remove the
SharedCache.