Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluetooth] Null annotations and SAT #13967

Merged
merged 9 commits into from
Mar 6, 2023
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Dec 16, 2022

This and some more PR's to follow focus on reducing the SAT warnings and add null annotations to the set of bluetooth bindings. While doing so i tried to change as less as possible to the inner workings as it is a complex set.

Hopefully some (not yet) bugs are fixed in advance and no new ones are introduced.

Depends on #13974

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the work in progress A PR that is not yet ready to be merged label Dec 16, 2022
@lsiepel
Copy link
Contributor Author

lsiepel commented Dec 16, 2022

I do have some questions. This and the related bluetooth bindings have warnings about the bridge id. I don;t understand why this is in place. So maybe someone can point me in the right direction, if this is fixable or not.

[WARNING] OH-INF.thing.thing-types.xml:[0]
Missing the supported bridge with id roaming
[WARNING] OH-INF.thing.thing-types.xml:[0]
Missing the supported bridge with id bluegiga
[WARNING] OH-INF.thing.thing-types.xml:[0]
Missing the supported bridge with id bluez

Also the BluetoothDiscoveryService.java shows some null pointer related issues i find hard to addres without making the code sloppy and unreadable. Hopefully someone can point me in the right direction.

The build fails, the needed change in bluetooth.bluegiga has allready been prepared.

@lsiepel lsiepel added awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build work in progress A PR that is not yet ready to be merged labels Dec 16, 2022
@lsiepel lsiepel requested a review from a team December 23, 2022 12:50
@lsiepel lsiepel added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jan 3, 2023
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Mar 5, 2023
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for this clean-up!

@kaikreuzer kaikreuzer merged commit 539f49e into openhab:main Mar 6, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Mar 6, 2023
@kaikreuzer kaikreuzer removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Mar 6, 2023
@lsiepel lsiepel deleted the bluetooth-sat branch March 6, 2023 16:45
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* null annotation, checkstyle, dependency

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* null annotation, checkstyle, dependency

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur pushed a commit to jlaur/openhab-addons that referenced this pull request Jul 28, 2023
Fixes openhab#15313

Partially reverts openhab#13967

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur pushed a commit to jlaur/openhab-addons that referenced this pull request Jul 28, 2023
Fixes openhab#15313

Partially reverts openhab#13967

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur added a commit to jlaur/openhab-addons that referenced this pull request Jul 28, 2023
Fixes openhab#15313

Partially reverts openhab#13967

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
kaikreuzer pushed a commit that referenced this pull request Jul 28, 2023
Fixes #15313

Partially reverts #13967

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
kaikreuzer pushed a commit that referenced this pull request Jul 28, 2023
Fixes #15313

Partially reverts #13967

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@dw-8 dw-8 mentioned this pull request Nov 13, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Fixes openhab#15313

Partially reverts openhab#13967

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants