Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unifi] Fix PoE bug with combination of other data/ports #14060

Merged
merged 1 commit into from
Dec 31, 2022
Merged

[unifi] Fix PoE bug with combination of other data/ports #14060

merged 1 commit into from
Dec 31, 2022

Conversation

Hilbrand
Copy link
Member

  • It seems to throw an exception when updating internal cache. It can happen if you have a switch that has both PoE ports and other PoE ports or data in the port override.
  • Fixed logout, should be POST instead of GET.
  • Fixed typo in channel-type.config.unifi.poeEnable.mode.option.pasv24 should be without appending v.
  • Removed compiler warnings.

@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Dec 24, 2022
@Hilbrand Hilbrand requested a review from mgbowman as a code owner December 24, 2022 13:55
jlaur
jlaur requested changes Dec 25, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Is this related to https://community.openhab.org/t/unifi-oh-3-4-not-working-any-more/142260? If this is a regression from 3.4, should it be cherry-picked into the 3.4 hotfix branch after being merged?

...binding.unifi/src/main/java/org/openhab/binding/unifi/internal/api/dto/UniFiSwitchPorts.java Outdated Show resolved Hide resolved
@Hilbrand
[unifi] Fix bug with combination of other data/ports
1882fec 
- It seems to throw an exception when updating internal cache. It can happen if you have a switch that has both PoE ports and other PoE ports or data in the port override.
- Fixed logout, should be POST instead of GET.
- Fixed typo in channel-type.config.unifi.poeEnable.mode.option.pasv24 should be without appending v.
- Removed compiler warnings.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@Hilbrand Hilbrand force-pushed the unifi-4.0-poe-fixes branch from a1ed0b1 to 1882fec Compare December 28, 2022 16:20
@Hilbrand Hilbrand requested a review from jlaur December 28, 2022 16:20
@Hilbrand
Copy link
Member Author

@jlaur It's not a regression specific for 3.4.0. The 3.3.0 version didn't work correctly for PoE in some cases. There was a fix in 3.4.0, but that turned out not to fix all cases. This fix should fix that.

jlaur
jlaur approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur
Copy link
Contributor

jlaur commented Dec 28, 2022

@Hilbrand, @lolodomo - I would suggest to include this in the hotfix, even if it was not a regression from 3.4. WDYT?

@jlaur jlaur merged commit 202a864 into openhab:main Dec 31, 2022
@jlaur jlaur added this to the 4.0 milestone Dec 31, 2022
@Hilbrand Hilbrand deleted the unifi-4.0-poe-fixes branch December 31, 2022 14:53
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@Hilbrand @borazslo
[unifi] Fix bug with combination of other data/ports (openhab#14060)
820f8de 
- It seems to throw an exception when updating internal cache. It can happen if you have a switch that has both PoE ports and other PoE ports or data in the port override.
- Fixed logout, should be POST instead of GET.
- Fixed typo in channel-type.config.unifi.poeEnable.mode.option.pasv24 should be without appending v.
- Removed compiler warnings.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@Hilbrand @nemerdaud
[unifi] Fix bug with combination of other data/ports (openhab#14060)
e67bd3b 
- It seems to throw an exception when updating internal cache. It can happen if you have a switch that has both PoE ports and other PoE ports or data in the port override.
- Fixed logout, should be POST instead of GET.
- Fixed typo in channel-type.config.unifi.poeEnable.mode.option.pasv24 should be without appending v.
- Removed compiler warnings.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@Hilbrand @renescherer
[unifi] Fix bug with combination of other data/ports (openhab#14060)
a3df667 
- It seems to throw an exception when updating internal cache. It can happen if you have a switch that has both PoE ports and other PoE ports or data in the port override.
- Fixed logout, should be POST instead of GET.
- Fixed typo in channel-type.config.unifi.poeEnable.mode.option.pasv24 should be without appending v.
- Removed compiler warnings.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@mgbowman mgbowman Awaiting requested review from mgbowman mgbowman is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hilbrand @jlaur