[tesla] Fix discovery of Tesla vehicles from account #14070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
lolodomo
requested changes
Dec 27, 2022
| @@ -81,31 +81,15 @@ public void deactivate() { | |||
|
|
|||
| @Override | |||
| public void vehicleFound(Vehicle vehicle, VehicleConfig vehicleConfig) { | |||
There was a problem hiding this comment.
Please add @Nullable to the parameter vehicleConfig.
There was a problem hiding this comment.
The whole class/binding does not yet have null annotations on it, I wouldn't want to do it as part of a bug fix.
bundles/org.openhab.binding.tesla/src/main/resources/OH-INF/i18n/tesla.properties
Show resolved
Hide resolved
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
@lolodomo Thanks for the quick review - I have addressed your comments. |
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
* Fix discovery of Tesla vehicles from account Signed-off-by: Kai Kreuzer <kai@openhab.org>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Fix discovery of Tesla vehicles from account Signed-off-by: Kai Kreuzer <kai@openhab.org>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* Fix discovery of Tesla vehicles from account Signed-off-by: Kai Kreuzer <kai@openhab.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, vehicles that are asleep (which is the normal situation) are not discovered and thus not put into the Inbox, what is fairly unexpected for the user.
This change makes sure that every vehicle of the account is added to the Inbox. It defers the identification of the model to a later stage as this is only required for creating the Thing with all its channels.
Signed-off-by: Kai Kreuzer kai@openhab.org