Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluetooth.generic] Upgrade Gson to 2.9.1 #14092

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 28, 2022

Related to #14088
Triggered by openhab/openhab-core#2994 (where Gson was upgraded to 2.9.1)

JAR for testing: org.openhab.binding.bluetooth.generic-4.0.0-SNAPSHOT.jar
(I have not been able to test this myself)

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from cpmeister as a code owner December 28, 2022 19:53
@jlaur
Copy link
Contributor Author

jlaur commented Dec 28, 2022

@stefan-hoehn - are you able to test this? Link to JAR is provided in description.

@stefan-hoehn
Copy link
Contributor

The problem testing it (and for sure all the other bundle issues) is that 4.0 is not starting at all because all of this (so I wouldn't know how "replace" the bundles even. I would actually recommend all of the four related fixes will be merged and as soon as there is a new build I can update the installation and see how it behaves. The related issue for that is https://community.openhab.org/t/oh4-on-buster/142645/21

Would that be okay in this case?

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 1d54e9c into openhab:main Dec 29, 2022
@wborn wborn added this to the 4.0 milestone Dec 29, 2022
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur deleted the 14088-bluetooth-upgrade-gson branch February 4, 2023 10:22
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants