Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bondhome] Fix fatal Null Pointer errors #14103

Merged
merged 4 commits into from
Dec 30, 2022
Merged

[bondhome] Fix fatal Null Pointer errors #14103

merged 4 commits into from
Dec 30, 2022

Conversation

mlobstein
Copy link
Contributor

I just got a bond bridge today. I tried to use the binding and ran into several fatal errors that stopped the binding from functioning:

  1. When I changed the IP of the bridge the binding would fail connecting to the old address. An error in the translation file caused an exception when calling setBridgeOffline(),
  2. In my bridge, I set up a 'Light' aka 'LT' item and this is apparently not supported by BondDeviceType. This caused the discovery service to fail when the BondDevice with a null 'type' was encountered.
  3. The list of actions in one or more BondDevice objects contained null entries that would cause an NPE in deleteExtraChannels()

@mlobstein
Fix fatal Null Pointer errors
df9c070 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein
revert autoformatted code
6622b0a 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein added the bug An unexpected problem or unintended behavior of an add-on label Dec 29, 2022
@mlobstein mlobstein requested a review from ccutrer as a code owner December 29, 2022 06:13
lsiepel
lsiepel reviewed Dec 29, 2022
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlobstein
review changes
0bb1fa5 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein
review changes
a835e09 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lolodomo
lolodomo approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit dd8eb47 into openhab:main Dec 30, 2022
@lolodomo lolodomo added this to the 4.0 milestone Dec 30, 2022
@jlaur
Copy link
Contributor

jlaur commented Dec 30, 2022

@ccutrer, @lolodomo, @mlobstein - should we include this in the upcoming 3.4.1 hotfix? In terms of risk, there is probably not a lot of users yet since it's a new binding. But it seems this bug could be quite annoying for impacted new users, so seems critical?

@lolodomo
Copy link
Contributor

lolodomo commented Dec 30, 2022 •
edited
Loading

Take care, there was another PR recently merged. If this one is cherry picked in 3.4.x, the other should be done first.

@lolodomo
Copy link
Contributor

I am talking about PR #13986 .

@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Dec 30, 2022
jlaur pushed a commit that referenced this pull request Dec 30, 2022
@mlobstein @jlaur
[bondhome] Fix fatal Null Pointer errors (#14103)
99d9566 
* Fix fatal Null Pointer errors

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein deleted the bondhome_npe2 branch December 30, 2022 15:33
@mlobstein mlobstein mentioned this pull request Jan 4, 2023
Merged
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@mlobstein @borazslo
[bondhome] Fix fatal Null Pointer errors (openhab#14103)
3ed16dd 
* Fix fatal Null Pointer errors

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@ccutrer ccutrer mentioned this pull request Jan 13, 2023
Closed
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@mlobstein @psmedley
[bondhome] Fix fatal Null Pointer errors (openhab#14103)
c2e8a64 
* Fix fatal Null Pointer errors

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@mlobstein @nemerdaud
[bondhome] Fix fatal Null Pointer errors (openhab#14103)
f549ce0 
* Fix fatal Null Pointer errors

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccutrer ccutrer ccutrer approved these changes

@lsiepel lsiepel lsiepel approved these changes

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mlobstein @jlaur @lolodomo @ccutrer @lsiepel