[mimictts] Fix ssml and playing from audiosinks using the audio servlet #14120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalgwen
force-pushed
the
mimictts_fix_ssml_servlet_sink
branch
from
9c5be8e to
85e1fbf
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/mimic-text-to-speech/137040/12 |
lolodomo
requested changes
Jan 4, 2023
| if (!config.workaroundServletSink) { | ||
| return new InputStreamAudioStream(inputStreamFromMimic, AUDIO_FORMAT, length); | ||
| } else { | ||
| // Some audio sinks use the openHAB servlet to get audio. This servlet require the |
There was a problem hiding this comment.
Just for my information, which ones ?
There was a problem hiding this comment.
I only reproduced the issue and tested my fix against the chromecast binding, but a user also reports error with webaudio and yamaha musiccast.
Nobody complains, but as far as I remember, the squeezebox binding also uses the audio servlet.
bundles/org.openhab.voice.mimictts/src/main/resources/OH-INF/i18n/mimictts_fr.properties
Outdated
Show resolved
Hide resolved
lolodomo
added
the
enhancement
…vlet Fix : - ssml not working - add an option to store the audio on a file before sending it to openhab. It enables audiosink based on the audio servlet to play the sound (the servlet requires the getClonedStream method, unavailable with a pure streaming approach). The files are stored in the user data directory and deleted as soon as possible (stream close detection). - fix error with voice name not encoded Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Rebasing. Remove i18n, typo in README, and year 2023 Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
dalgwen
force-pushed
the
mimictts_fix_ssml_servlet_sink
branch
from
85e1fbf to
74f5191
Compare
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…et (openhab#14120) * [mimictts] Fix ssml and playing from an audiosink using the audio servlet Fix : - ssml not working - add an option to store the audio on a file before sending it to openhab. It enables audiosink based on the audio servlet to play the sound (the servlet requires the getClonedStream method, unavailable with a pure streaming approach). The files are stored in the user data directory and deleted as soon as possible (stream close detection). - fix error with voice name not encoded Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
…et (openhab#14120) * [mimictts] Fix ssml and playing from an audiosink using the audio servlet Fix : - ssml not working - add an option to store the audio on a file before sending it to openhab. It enables audiosink based on the audio servlet to play the sound (the servlet requires the getClonedStream method, unavailable with a pure streaming approach). The files are stored in the user data directory and deleted as soon as possible (stream close detection). - fix error with voice name not encoded Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix :
Thanks rotec52 for spotting it and providing solution.
Signed-off-by: Gwendal Roulleau gwendal.roulleau@gmail.com