[astro] Add option to force event to occur #14132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsiepel <leosiepel@gmail.com>
lsiepel
added
the
enhancement
…d-earliest-or-latest-channel-time
lolodomo
added
rebuild
…d-earliest-or-latest-channel-time
Signed-off-by: lsiepel <leosiepel@gmail.com>
lolodomo
requested changes
Jan 29, 2023
bundles/org.openhab.binding.astro/src/main/resources/OH-INF/config/config.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <leosiepel@gmail.com>
lsiepel
deleted the
11424-astro-should-respect-configured-earliest-or-latest-channel-time
branch
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* fix issue 11424 Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* fix issue 11424 Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* fix issue 11424 Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lsiepel leosiepel@gmail.com
Trigger channels have an earliest start / latest end option to 'manualy' control/override event (e.g. sunrise, sunset ) starts/ ends to occur. There are cases that the event is not happening at all (e.g. astro dawn during summer in Sweden). This PR adds an option to the trigger channel config to 'force' the event to take place even when it is actually not happening. For the start/ end it uses the earliest /latest config setting.
this setting defaults to false, so it should not affect existing set-ups.
Also add tests to assure behaviour is consistent with and without the ChannelConfig 'forceEvents' set to true.
Resolves: #11424