[netatmo] Add the ability to append a postfix to registered webhook #14140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clinique <gael@lhopital.org>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
Signed-off-by: clinique <gael@lhopital.org>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
Signed-off-by: clinique <gael@lhopital.org>
jlaur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing PR #14123 to OH4
The problem was registering a webhook like https://mydomain:443/netatmo/webhook/5xxxxxddddggggg47d3 was really difficult to address behind a reverse proxy relaying the payload (one day of effort tuning nginx without success). With this extra parameter it's easy to register https://mydomain:443/netatmo/webhook/5xxxxxddddggggg47d3/ or https://mydomain:443/netatmo/webhook/5xxxxxddddggggg47d3/webhook.php
Signed-off-by: clinique gael@lhopital.org