[mail] Make actions names for DSL rules consistent with documentation #14151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep old names for backward compatibility. Actions names are now consistent over all rule engines. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
@jlaur : if you get time to review that PR. Nothing critical but would allow to be consistent with the documentation. |
jlaur
requested changes
Jan 29, 2023
...hab.binding.mail/src/main/java/org/openhab/binding/mail/internal/action/SendMailActions.java
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@jlaur : ready for round 2. |
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…openhab#14151) * [mail] Make actions names for DSL rules consistent with documentation Keep old names for backward compatibility. Actions names are now consistent over all rule engines. * Review comment: use htmlContent as parameter name * Review comment: make consistent url and urlList parameters Signed-off-by: Laurent Garnier <lg.hc@free.fr>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
…openhab#14151) * [mail] Make actions names for DSL rules consistent with documentation Keep old names for backward compatibility. Actions names are now consistent over all rule engines. * Review comment: use htmlContent as parameter name * Review comment: make consistent url and urlList parameters Signed-off-by: Laurent Garnier <lg.hc@free.fr>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
…openhab#14151) * [mail] Make actions names for DSL rules consistent with documentation Keep old names for backward compatibility. Actions names are now consistent over all rule engines. * Review comment: use htmlContent as parameter name * Review comment: make consistent url and urlList parameters Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep old names for backward compatibility (DSL rule).
Actions names are now consistent over all rule engines.
Signed-off-by: Laurent Garnier lg.hc@free.fr