[chromecast] Fix thing go offline after stop command #14158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
lolodomo
reviewed
Jan 6, 2023
...hromecast/src/main/java/org/openhab/binding/chromecast/internal/ChromecastEventReceiver.java
Show resolved
Hide resolved
...ng.chromecast/src/main/java/org/openhab/binding/chromecast/internal/ChromecastCommander.java
Outdated
Show resolved
Hide resolved
...ng.chromecast/src/main/java/org/openhab/binding/chromecast/internal/ChromecastCommander.java
Show resolved
Hide resolved
Signed-off-by: lsiepel <leosiepel@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
* Restructure commander * Improve thing status handling on error Signed-off-by: lsiepel <leosiepel@gmail.com>
wborn
pushed a commit
that referenced
this pull request
Feb 5, 2023
* Restructure commander * Improve thing status handling on error Signed-off-by: lsiepel <leosiepel@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Restructure commander * Improve thing status handling on error Signed-off-by: lsiepel <leosiepel@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Restructure commander * Improve thing status handling on error Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lsiepel leosiepel@gmail.com
When the app running on the ChromeCast was stopped by switching the ON/OFF stop channel, the binding tried to stop the app without checking if it actually runs. Because the app wasn;t running, it gives an error and the thing goes offline.
This PR adds a check, and also restructured the class a bit.
Also when a command was givfen to play media by URL, but the URL was invalid or could not be loaded by the ChromeCast, the thing went offline for ~10 seconds. That mechanism is also change so that the Thing only goes offline when there is an actuall IOException, in other case it logs a warning about unplayable url.
3.4.1 Test JAR is here: https://1drv.ms/u/s!AnMcxmvEeupwjp4ILqWfPxAy7qJh4g?e=43fQde
Fixes: #9591 (tested and confirmed)