Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jeelink] Fixed wrong TX22 rain value #14224

Merged
merged 3 commits into from
Jan 21, 2023
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jan 15, 2023

  • Fixes the rain channel having a wrong value (divide instead of multiply)
  • Removes dependency of apache.commons.

Allready tested openHAB 3.4.2 jar here: https://1drv.ms/u/s!AnMcxmvEeupwjqVCE_YtH3yeZG5hXA?e=a1d7Hv

Fixes: #10358

Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Jan 15, 2023
@lsiepel lsiepel changed the title [jeelink] Fixed wrong rain value [jeelink] Fixed wrong TX22 rain value Jan 15, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit dd79074 into openhab:main Jan 21, 2023
@lolodomo lolodomo added this to the 4.0 milestone Jan 21, 2023
@lsiepel lsiepel deleted the jeelink-10358 branch January 21, 2023 09:43
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* Divide instead of multiply
* Remove apache.commons

Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* Divide instead of multiply
* Remove apache.commons

Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* Divide instead of multiply
* Remove apache.commons

Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jeelink] TX22 rain state calculation is wrong
2 participants