[velux] Do not use new API on Somfy devices #14225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
bug
|
For testing purposes the JAR file is here.. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/velux-new-openhab2-binding-feedback-welcome/32926/1524 |
jlaur
removed
the
regression
|
@andrewfg What about the deletion of line 121 (at least this is visible in the change view)? |
@gs4711 this line was moved from 121 to 98 |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* [velux] revert use of new API for Somfy devices * [velux] fix compare to wrong value Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* [velux] revert use of new API for Somfy devices * [velux] fix compare to wrong value Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* [velux] revert use of new API for Somfy devices * [velux] fix compare to wrong value Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh3-4-1-velux-rollershutter-state-not-updating/148758/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #13212 we implemented the new API calls, but it seems that Somfy devices do not support use of this new API.
So this PR reverts to the old API calls for Somfy devices
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch