Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unifi] Various stability improvements #14249

Merged
merged 3 commits into from
Jan 20, 2023
Merged

[unifi] Various stability improvements #14249

merged 3 commits into from
Jan 20, 2023

Conversation

Hilbrand
Copy link
Member

  • Fixed bug, causing nullpointer, in devices not reporting voltage/ampere values on PoE ports.
  • Added some null checks to avoid having null pointer exceptions.
  • Handled timeout exception that is in ExecutionException.
  • Improved handling case where server returns data, but it's not from the api, and therefor can't be parsed.
  • Improved adding additional text to the error messages by adding the reported exception message too.

@Hilbrand
[unifi] Various stability improvements
b0c15c7 
- Fixed bug, causing nullpointer, in devices not reporting voltage/ampere values on PoE ports.
- Added some null checks to avoid having null pointer exceptions.
- Handled timeout exception that is in ExecutionException.
- Improved handling case where server returns data, but it's not from the api, and therefor can't be parsed.
- Improved adding additional text to the error messages by adding the reported exception message too.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@Hilbrand Hilbrand requested a review from mgbowman as a code owner January 19, 2023 12:17
@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Jan 19, 2023
jlaur
jlaur requested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Just one clarification needed, and a very minor text correction suggested.

bundles/org.openhab.binding.unifi/src/main/resources/OH-INF/i18n/unifi.properties Outdated Show resolved Hide resolved
...fi/src/main/java/org/openhab/binding/unifi/internal/handler/UniFiControllerThingHandler.java Outdated Show resolved Hide resolved
@Hilbrand
[unifi] review comments
9a7cc38 
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@jlaur
Update bundles/org.openhab.binding.unifi/src/main/java/org/openhab/bi…
fe8f9e5 
…nding/unifi/internal/api/UniFiControllerRequest.java


Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
jlaur approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit bd23bcc into openhab:main Jan 20, 2023
@jlaur jlaur added this to the 4.0 milestone Jan 20, 2023
@Hilbrand Hilbrand deleted the fix-unifi branch January 20, 2023 13:12
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@Hilbrand @nemerdaud
[unifi] Various stability improvements (openhab#14249)
7140fbf 
* [unifi] Various stability improvements

- Fixed bug, causing nullpointer, in devices not reporting voltage/ampere values on PoE ports.
- Added some null checks to avoid having null pointer exceptions.
- Handled timeout exception that is in ExecutionException.
- Improved handling case where server returns data, but it's not from the api, and therefor can't be parsed.
- Improved adding additional text to the error messages by adding the reported exception message too.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@Hilbrand @renescherer
[unifi] Various stability improvements (openhab#14249)
7ee6327 
* [unifi] Various stability improvements

- Fixed bug, causing nullpointer, in devices not reporting voltage/ampere values on PoE ports.
- Added some null checks to avoid having null pointer exceptions.
- Handled timeout exception that is in ExecutionException.
- Improved handling case where server returns data, but it's not from the api, and therefor can't be parsed.
- Improved adding additional text to the error messages by adding the reported exception message too.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@Hilbrand @FordPrfkt
[unifi] Various stability improvements (openhab#14249)
57d7935 
* [unifi] Various stability improvements

- Fixed bug, causing nullpointer, in devices not reporting voltage/ampere values on PoE ports.
- Added some null checks to avoid having null pointer exceptions.
- Handled timeout exception that is in ExecutionException.
- Improved handling case where server returns data, but it's not from the api, and therefor can't be parsed.
- Improved adding additional text to the error messages by adding the reported exception message too.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@mgbowman mgbowman Awaiting requested review from mgbowman mgbowman is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hilbrand @jlaur