[siemenshvac] Initial contribution

[lo92fr]

Title

Add a binding for siemens Hvac interface (OZW672)

Description

This pull request is about adding a binding for siemens Hvac interface OZW672 (https://hit.sbt.siemens.com/RWD/app.aspx?rc=FR&lang=fr&module=Catalog&action=ShowProduct&key=BPZ:OZW672.01)

The OZW672 is a ethernet bridge for the LSB bus of Hvac device.
It implements a web interface that enable reading and setting of differents hvac parameters.
OZW672 also support a REST api.

This binding use this REST api to integrate OZW672 into openhab.

Testing

The binding support autodiscovery of the OZW672 interface using upnp.
After a few minutes, you should see the OZW672 bridge into your Inbox.
If not, power off and up OZW672.
You can also add the bridge manually.

After adding the bridge, you will have to go to bridge parameters, setting the password for the OZW672, and then restart openhab.
On restart, OZW672 will do autodiscovery phase from you installation during initialization.
This can be a little long : ~2 to 5 minutes depending of your installation.

After OZW672 bridge come up again, go back again to the "things" page of openhab.
Click on the add button, then click on the "siemensHvac" binding, and on the next page click on the "scan" button.
After a few second, openhab should list all you devices connect to the LSB bus.
If you have a simple home Hvac installation, it will generally find only one device.
Most common name for this device are something like "RVS41xxx.yyy".
This device represents the main controler inside your Hvac device.

After you add this RVS to your system, you can go into it, and Channels tabs will expose all your hvac settings.
Structure of the Channels should be the same as the one on the LCD screen of your Hvac device.
You may have a lot more of items that on your LCD screen because the device exposte all items, even the one for "specialist" guys.

[lo92fr]

Hello,

Not sure to understand the error message on the build.
The compilation is working on my side, if you can give me some advice about this error.

[lsiepel]

Hope the rebuild helps, don't see anything obvious wrong with the POM etc. You might want to look at the readme.md and the i18n files as they seem to be just the placeholders.

[clinique]

Partial review

[clinique]

Partial review.

[lo92fr]

Hello Gael,

Thanks for your review.
I've just updated the pull request with the requested modifications.

Laurent.

[lo92fr]

I also manage to fix the build.
Was missing a reference in bom/openhab-addons/pom.xml.

Laurent.

[clinique]

Second review

[freichen]

@lo92fr Amazing binding - thank you ! I tested it with an OZW672.01 connected to a RVP350 and the only issue I found was that Enumeration channels are auto-discovered as Number - for example:

[lo92fr]

hannels are auto-discovered as Number - for example:

Hello Freichen,

Not sure what are the good way to fix this.
Do you have some guidlines, or some other example binding I can look to fix this.

[lo92fr]

Hello Gaël,

@clinique : I'm not sure what are the current state of this pull request.
Do you wait more change from my side ?

[larnalcegid]

Hello,

Can some one can give an update about the integration of this pull request in main stream.

Thanks,
Laurent.

[larnalcegid]

@lo92fr Amazing binding - thank you ! I tested it with an OZW672.01 connected to a RVP350 and the only issue I found was that Enumeration channels are auto-discovered as Number - for example:

I've commit a fix for this, should be working as excepted now.

[larnalcegid]

Hello Gaël, Hello Freichen,

Any update on this ?
Let me know if any more changed is need.

Laurent.

[lo92fr]

or geting it merged for 4.2, I jus

Ok, look great.
I think at this time it could be a good thing if it's go in production so more people can test it in real case.
I would certainly work in most situation, but having more tester would enable to verify it on more various devices.

Laurent.

[jlaur]

I went through my list of open comments, and have reduced it to:

• [siemenshvac] Initial contribution #14263 (comment)
• [siemenshvac] Initial contribution #14263 (comment)
• [siemenshvac] Initial contribution #14263 (comment)
• [siemenshvac] Initial contribution #14263 (comment)
• [siemenshvac] Initial contribution #14263 (comment) (on me, will merge anyway if I won't find time to go deeper)

The last milestone will be built on Saturday, so if you are able to have a look before then, that would be awesome. I don't know if you plan to provide French translations, but there would then be a few days left to provide those at Crowdin.

[lo92fr]

I went through my list of open comments, and have reduced it to:

• [siemenshvac] Initial contribution - interface (OZW672) #14263 (comment)
• [siemenshvac] Initial contribution - interface (OZW672) #14263 (comment)
• [siemenshvac] Initial contribution - interface (OZW672) #14263 (comment)
• [siemenshvac] Initial contribution - interface (OZW672) #14263 (comment)
• [siemenshvac] Initial contribution - interface (OZW672) #14263 (comment) (on me, will merge anyway if I won't find time to go deeper)

The last milestone will be built on Saturday, so if you are able to have a look before then, that would be awesome. I don't know if you plan to provide French translations, but there would then be a few days left to provide those at Crowdin.

Hello @jlaur,

I take a look to your last review.
About the open comment:

• [siemenshvac] Initial contribution #14263 (comment)
  Have to check what we do on this one. I can provide a sample on how to create manually a thing.
  I done some test last week, and it worked.
  But it think no one will try to do it manually.
  I will just be perharps helpfull for some people where discovery is not working correctly, and will need to define the thing
  manually.

• [siemenshvac] Initial contribution #14263 (comment)
  updateStatus thing : will need a few more test, but I don't think the flipping case you describe will occurs.

• [siemenshvac] Initial contribution #14263 (comment)
  adding test coverage on normalizeDescriptor : still need to be done, will try to do it today.

• [siemenshvac] Initial contribution #14263 (comment)
  I see you just push a comment, let me check that.

• [siemenshvac] Initial contribution #14263 (comment)
  Has we have lot of discussion on this

[lo92fr]

st milestone will be built on Saturday, so if you a

I've checked your last comment, and commit some minor modifications.
For french translations, I've already have them ready on my side, so it should be ok to provide them in Crowdin at the beginning of next week.

Laurent.

[jlaur]

@lo92fr - just to be sure, do you plan on looking closer a the few remaining comments here today? We can still merge, but if you are actively working on something, I would hold back the merge for a bit to avoid follow-up PR's.

[lo92fr]

@lo92fr - just to be sure, do you plan on looking closer a the few remaining comments here today? We can still merge, but if you are actively working on something, I would hold back the merge for a bit to avoid follow-up PR's.

Hello @jlaur,

No, I'm not there this afternoon, so I will not do other modification.
You can merge when you want.

Laurent.

[jlaur]

Thanks again for your contribution, and also for addressing review comments and enduring this long review process we've been through.

Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui