[androidtv] AndroidTV Binding initial contribution

[morph166955]

This is the initial contribution of the AndroidTV binding. AndroidTV has a unique place in the market where it exists in several different vendors in the market. This creates the basic binding framework and adds the Nvidia ShieldTV protocol (which was reverse engineered from the Nvidia ShieldTV Android App) and version 2 of the GoogleTV protocol (which was reverse engineered from the GoogleTV Android App). Discovery is provided by mDNS.

All devices use the GoogleTV protocol as the base for command/control/information. The Nvidia ShieldTV adds the ShieldTV protocol on top for additional metadata and application control.

This version provides connectivity, authentication via the on-screen PIN based process, PKI support for certificates, keypress support for all identified keys, and app control/awareness/information.

This is a follow-on to the original shieldtv PR (#13934) which was closed in favor of a more encompassing androidtv binding to better support the community.

Fixes #14315

[morph166955]

A test jar is available through the marketplace at https://community.openhab.org/t/androidtv-binding-3-2-0-4-0-0/142203

[morph166955]

Created:

openhab/openhab-docs#2001 (Now merged)

and

#14315

As per guidelines

[morph166955]

I'm OK with this, although it would be preferable to do now to avoid update instructions for removing the obsolete channel again.

Just to be clear on my intentions, I'm fine with adding the CLI commands as an alternative however I'm going to leave the channel in place as well as some users do prefer this method. Also, as this has been on the marketplace for 6 months now we would already have to update there anyway.

[morph166955]

Updated to the newest snapshot and I'm getting an NPE on start. Just pushed a commit to resolve that.

2023-05-22 08:58:54.129 [ERROR] [y.mdns.internal.MDNSDiscoveryService] - Participant 'org.openhab.binding.androidtv.internal.discovery.GoogleTVDiscoveryParticipant' threw an exception
java.lang.NullPointerException: Cannot invoke "String.replace(java.lang.CharSequence, java.lang.CharSequence)" because the return value of "javax.jmdns.ServiceInfo.getPropertyString(String)" is null
        at org.openhab.binding.androidtv.internal.discovery.GoogleTVDiscoveryParticipant.getThingUID(GoogleTVDiscoveryParticipant.java:101) ~[?:?]
        at org.openhab.binding.androidtv.internal.discovery.GoogleTVDiscoveryParticipant.createResult(GoogleTVDiscoveryParticipant.java:78) ~[?:?]
        at org.openhab.core.config.discovery.mdns.internal.MDNSDiscoveryService.createDiscoveryResult(MDNSDiscoveryService.java:222) ~[?:?]
        at org.openhab.core.config.discovery.mdns.internal.MDNSDiscoveryService.considerService(MDNSDiscoveryService.java:214) ~[?:?]
        at org.openhab.core.config.discovery.mdns.internal.MDNSDiscoveryService.serviceResolved(MDNSDiscoveryService.java:207) ~[?:?]
        at javax.jmdns.impl.ListenerStatus$ServiceListenerStatus.serviceResolved(ListenerStatus.java:106) ~[?:?]
        at javax.jmdns.impl.JmDNSImpl$1.run(JmDNSImpl.java:911) ~[?:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

[morph166955]

@wborn checking in again on this. We're getting close to the code getting locked for the 4.0.0 release and I'd really like to get this merged in for that. Thanks!

[morph166955]

Google updated the GoogleTV protocol to version 4.39. Two minor commits have be pushed to update the login string to resolve an issue posted to the forum and to make a few small changes to the checks and logging for the PIN process.

[jlaur]

@wborn - what is the status of your review?

[morph166955]

@wborn Please let me know if there's anything else for this. Thanks!

[wborn]

Thanks for addressing the comments. 👍
Sorry, I was a bit busy but I've added a few more comments below:

[morph166955]

@wborn I've pushed several commits to resolve the bulk of the comments. I've left comments on the rest for your consideration.

EDIT: Also to note, I've not had time to do thorough regression testing on these changes. I don't see any reason they should fail, and they all compile clean, but just noting for record.

[morph166955]

@wborn Checking in to see if there's anything else on this.

[wborn]

Thanks for addressing the comments! I've added a few more below. After that I think it's nice and clean. 🙂

[morph166955]

@wborn I've pushed the fixes as requested. I'm going to push the current code to the addon marketplace as well.

[wborn]

Many thanks! 👍 Let's merge it! 🚀

[morph166955]

Thank you @wborn!

@jlaur I haven't forgotten you, I'll be working on those follow-on PRs in the next few days in hopes to get them pulled in prior to the final 4.0.0 release.