-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hue] Handle unexpected empty response from API #14297
Conversation
Fix openhab#14218 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
In the issue, we discovered that the API can sometimes return an empty response (with status code 200) when requesting the sensors data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. Only one minor comment.
...ng.hue/src/main/java/org/openhab/binding/hue/internal/exceptions/EmptyResponseException.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe a candidate for 3.4.x branch? |
Agreed, I'll cherry-pick in the evening. |
Fix #14218 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix openhab#14218 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix openhab#14218 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix openhab#14218 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix #14218
Signed-off-by: Laurent Garnier lg.hc@free.fr