[tesla] Fix account going offline every few seconds #14300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
|
The CI build failed |
lolodomo
added
rebuild
|
@lolodomo CI build failure was unrelated. Retriggering made it succeed. |
@jlaur : can you please cherry-pick in branch 3.4.x? |
jlaur
pushed a commit
that referenced
this pull request
Jan 31, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an account reaches the threshold of failed api calls, it is set to OFFLINE.
Once this happens, it will immediately go to OFFLINE again every time that it becomes back ONLINE.
This causes the vehicle to stay online and thus leads to vampire drain.
This PR resets the counter, so that the Thing stays ONLINE until the threshold is reached again.
This fix might quality as a backport to 3.4.x.
Signed-off-by: Kai Kreuzer kai@openhab.org