Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[influxdb] Code improvements and enhancements #14304

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 31, 2023

This brings the code improvements regarding metadata handling and code simplifications as well as upgrades of dependencies that were originally contributed as smarthomej/addons#71 and smarthomej/addons#169.

Signed-off-by: Jan N. Klug github@klug.nrw

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Jan 31, 2023
@J-N-K J-N-K requested a review from lujop as a code owner January 31, 2023 18:08
J-N-K added 2 commits January 31, 2023 19:59
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing these improvements back here. Only some minor findings from my side.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@jlaur jlaur merged commit ed7159c into openhab:main Feb 13, 2023
@jlaur jlaur added this to the 4.0 milestone Feb 13, 2023
@J-N-K J-N-K deleted the inlux-upgrade branch February 14, 2023 08:21
SMHRambo pushed a commit to SMHRambo/openhab-addons that referenced this pull request Feb 14, 2023
* [influxdb] code improvements

Signed-off-by: Jan N. Klug <github@klug.nrw>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [influxdb] code improvements

Signed-off-by: Jan N. Klug <github@klug.nrw>
@florian-h05
Copy link
Contributor

@J-N-K
Since my upgrade to the 4.0-SNAPSHOTs my openHAB logs get flooded with hundreds of this log message:

2023-03-05 12:35:03.618 [INFO ] [b.internal.InfluxDBStateConvertUtils] - Could not find item 'null' in registry

This happens approx every minute.

@J-N-K
Copy link
Member Author

J-N-K commented Mar 5, 2023

Interesting. Can you set influxdb to TRACE logging and show the request that is done before? It seems that something is wrong with the item name retrieval while querying the database.

@florian-h05
Copy link
Contributor

Something like this?

2023-03-05 13:05:00.631 [TRACE] [.influxdb.InfluxDBPersistenceService] - Query-Filter: itemname: Aussentemperatur, ordering: ASCENDING, state: null,  operator: EQ, getBeginDate: 2023-03-04T13:05:00.627+01:00, getEndDate: null, getPageSize: 2147483647, getPageNumber: 0
2023-03-05 13:05:00.632 [TRACE] [.influxdb.InfluxDBPersistenceService] - Query from(bucket:"openhab")
	|> range(start:2023-03-04T12:05:00.627000000Z)
	|> filter(fn: (r) => r["_measurement"] == "Aussentemperatur")
	|> keep(columns:["_measurement", "_time", "_value"])
	|> sort(desc:false, columns:["_time"])

I've alse attached the full log since I enabled trace logging for InfluxDB: openhab.log

@J-N-K
Copy link
Member Author

J-N-K commented Mar 5, 2023

That's fine. I assume Aussentemperatur is the item name, correct?

@florian-h05
Copy link
Contributor

Correct.

@J-N-K
Copy link
Member Author

J-N-K commented Mar 5, 2023

Which InfluxDB version? If 2, then I found the issue.

@florian-h05
Copy link
Contributor

Version 2.6.1

renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* [influxdb] code improvements

Signed-off-by: Jan N. Klug <github@klug.nrw>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* [influxdb] code improvements

Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants