[telegram] Invalid escape of underscore character when sending messages (Revert "Solves issue #11691 (#13758)") #14314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b#14204) This PR reverts commit 1d23c32 and fix openhab#14204. Signed-off-by: Daniel Schröter d.schroeter@gmx.de Signed-off-by: Daniel Schröter <d.schroeter@gmx.de>
holgerfriedrich
added
the
bug
|
As this is a regression, i hope it is considered as a patch to 3.4.x |
My understanding from the linked issue: Yes, it does. But it's the better evil as it seems the fix broke more than it fixed. So a proper fix (or documentation update) should probably be made. But as a quick fix, which can also be backported to 3.4.x, this revert seems okay. @lolodomo, I'll let you merge. I can then cherry-pick to 3.4.x if you agree. |
|
Ok to apply the change to branch 3.4.x |
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…b#14204) (openhab#14314) This PR reverts commit 1d23c32 and fix openhab#14204. Signed-off-by: Daniel Schröter <d.schroeter@gmx.de>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…b#14204) (openhab#14314) This PR reverts commit 1d23c32 and fix openhab#14204. Signed-off-by: Daniel Schröter <d.schroeter@gmx.de>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
…b#14204) (openhab#14314) This PR reverts commit 1d23c32 and fix openhab#14204. Signed-off-by: Daniel Schröter <d.schroeter@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1d23c32 broke sending underscore character in messages #14204
This PR reverts commit 1d23c32 and fix #14204.
Signed-off-by: Daniel Schröter d.schroeter@gmx.de