Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snmp] Upgrades and enhancements #14330

Merged
merged 6 commits into from
Feb 4, 2023
Merged

[snmp] Upgrades and enhancements #14330

merged 6 commits into from
Feb 4, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 3, 2023 •
edited
Loading

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K J-N-K requested review from svilenvul and a team as code owners February 3, 2023 20:25
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Feb 4, 2023
J-N-K added 2 commits February 4, 2023 09:55
@J-N-K
[snmp] Upgrades and enhancements
b7da275 
- bug: improve test stability
- enhancement: add support for UoM
- bug: fix misleading error message
- bug: fix initialization exceptions
- enhancement: Add support for SNMPv3
- enhancement: add opaque value handling

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
codeowners
303d087 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Revert "Auxiliary commit to revert individual files from b7da275"
323646c 
This reverts commit 81a0e1c147f2929800836825646c45da490d27b8.

Signed-off-by: Jan N. Klug <github@klug.nrw>
jlaur
jlaur requested changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport. LGTM. Only a few minor comments for the README. Please also regenerate the I18N properties file.

bundles/org.openhab.binding.snmp/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.snmp/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.snmp/README.md Outdated Show resolved Hide resolved
J-N-K added 2 commits February 4, 2023 14:20
@J-N-K
address review comments
3388f89 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
i18n
7102359 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Feb 4, 2023

Done.

@J-N-K
some grammar
2a2febf 
Signed-off-by: Jan N. Klug <github@klug.nrw>
jlaur
jlaur approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit fc57f02 into openhab:main Feb 4, 2023
@jlaur jlaur added this to the 4.0 milestone Feb 4, 2023
@jlaur jlaur removed the bug An unexpected problem or unintended behavior of an add-on label Feb 4, 2023
@J-N-K J-N-K deleted the snmp branch February 4, 2023 15:18
@jlaur jlaur mentioned this pull request Feb 15, 2023
Closed
@lsiepel lsiepel mentioned this pull request Feb 15, 2023
Closed
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@J-N-K @nemerdaud
[snmp] Upgrades and enhancements (openhab#14330)
52f7f4e 
* [snmp] Upgrades and enhancements

- bug: improve test stability
- enhancement: add support for UoM
- bug: fix misleading error message
- bug: fix initialization exceptions
- enhancement: Add support for SNMPv3
- enhancement: add opaque value handling

Signed-off-by: Jan N. Klug <github@klug.nrw>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@J-N-K @renescherer
[snmp] Upgrades and enhancements (openhab#14330)
436a75c 
* [snmp] Upgrades and enhancements

- bug: improve test stability
- enhancement: add support for UoM
- bug: fix misleading error message
- bug: fix initialization exceptions
- enhancement: Add support for SNMPv3
- enhancement: add opaque value handling

Signed-off-by: Jan N. Klug <github@klug.nrw>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@J-N-K @FordPrfkt
[snmp] Upgrades and enhancements (openhab#14330)
80473a4 
* [snmp] Upgrades and enhancements

- bug: improve test stability
- enhancement: add support for UoM
- bug: fix misleading error message
- bug: fix initialization exceptions
- enhancement: Add support for SNMPv3
- enhancement: add opaque value handling

Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@svilenvul svilenvul Awaiting requested review from svilenvul

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@J-N-K @jlaur