Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airquality] Add missing binding description #14332

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Feb 4, 2023

Previously in binding.xsd:

<xs:element name="description" type="xs:string" minOccurs="0"/>

In addon.xsd:

<xs:element name="description" type="xs:string"/>

This had the following consequence:

2023-02-03 22:04:49.015 [WARN ] [ig.xml.osgi.XmlDocumentBundleTracker] - The XML document '/OH-INF/addon/addon.xml' in module 'org.openhab.binding.airquality' could not be parsed: The node 'description' is missing!
---- Debugging information ----
message             : The node 'description' is missing!
class               : org.openhab.core.addon.xml.internal.AddonInfoXmlResult
required-type       : org.openhab.core.addon.xml.internal.AddonInfoXmlResult
converter-type      : org.openhab.core.addon.xml.internal.AddonInfoConverter
path                : /addon
line number         : 9
version             : 1.4.19
-------------------------------
com.thoughtworks.xstream.converters.ConversionException: The node 'description' is missing!
---- Debugging information ----
message             : The node 'description' is missing!
class               : org.openhab.core.addon.xml.internal.AddonInfoXmlResult
required-type       : org.openhab.core.addon.xml.internal.AddonInfoXmlResult
converter-type      : org.openhab.core.addon.xml.internal.AddonInfoConverter
path                : /addon
line number         : 9
version             : 1.4.19
-------------------------------
	at org.openhab.core.config.xml.util.NodeIterator.next(NodeIterator.java:122) ~[?:?]
	at org.openhab.core.config.xml.util.NodeIterator.nextValue(NodeIterator.java:181) ~[?:?]
	at org.openhab.core.addon.xml.internal.AddonInfoConverter.unmarshal(AddonInfoConverter.java:84) ~[?:?]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:74) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:72) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:68) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:52) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.TreeUnmarshaller.start(TreeUnmarshaller.java:136) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.unmarshal(AbstractTreeMarshallingStrategy.java:32) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1421) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1399) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.XStream.fromXML(XStream.java:1350) ~[bundleFile:1.4.19]
	at com.thoughtworks.xstream.XStream.fromXML(XStream.java:1304) ~[bundleFile:1.4.19]
	at org.openhab.core.config.xml.util.XmlDocumentReader.readFromXML(XmlDocumentReader.java:105) ~[bundleFile:?]
	at org.openhab.core.config.xml.osgi.XmlDocumentBundleTracker.parseDocuments(XmlDocumentBundleTracker.java:396) [bundleFile:?]
	at org.openhab.core.config.xml.osgi.XmlDocumentBundleTracker.processBundle(XmlDocumentBundleTracker.java:382) [bundleFile:?]
	at org.openhab.core.config.xml.osgi.XmlDocumentBundleTracker$2.run(XmlDocumentBundleTracker.java:347) [bundleFile:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
	at java.lang.Thread.run(Thread.java:833) [?:?]

I checked other bindings as well, and only this one didn't have a description.

Related to openhab/openhab-core#3050

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Feb 4, 2023
@jlaur jlaur requested a review from kubawolanin as a code owner February 4, 2023 07:08
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

lolodomo commented Feb 4, 2023

An entry already exists in airquality.properties file.

@lolodomo lolodomo merged commit 6ecb9ba into openhab:main Feb 4, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 4, 2023
@jlaur
Copy link
Contributor Author

jlaur commented Feb 4, 2023

An entry already exists in airquality.properties file.

Yes, that's where I copied it from.😉

@jlaur jlaur deleted the airquality-addon-xml branch February 4, 2023 10:03
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants