-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsscripting] Extend mapping of openhab-js classes to native openHAB counterparts #14335
Conversation
…arts Related to openhab/openhab-js#98. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@jlaur Can you please review this? |
@florian-h05 - I'm also not confident with bnd files, perhaps another @openhab/add-ons-maintainers could have a look? |
@digitaldan Are you confident with bnd files? |
No, although the changes look pretty straight forward to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reference openhab/openhab-addons#14335. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…counterparts (openhab#14335) Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…counterparts (openhab#14335) Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…counterparts (openhab#14335) Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…counterparts (openhab#14335) Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Addon part of openhab/openhab-js#98.
Description
This PR extends the target type mapping inside the JS Scripting addon to also translate the following openhab-js classes to their native openHAB Java counterparts when passing to Java methods:
Item
->org.openhab.core.items.Item
Quantity
->org.openhab.core.library.types.QuantityType
Regarding the updated bnd file: I hope I did the right (if I understood the docs correctly I did), but would be nice if one could have a look and verify that it is correct what I did.
Testing
Use the following script to test:
... or trust me given the simplicity of the code when comparing to the existing and well-working code.