Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Adjust to core-changes (UoM) #14389

Closed
wants to merge 26 commits into from
Closed

[WIP] Adjust to core-changes (UoM) #14389

wants to merge 26 commits into from

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 12, 2023

@J-N-K
Fix itests
be72800 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
suppressions
9576538 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Angle
496949f 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Power
018b7bd 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Speed
6d197b9 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:ElectricCurrent
6fdc882 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:ElectricPotential
eb28e46 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:ElectricCharge Number:ElectricResistance
4f0b7ae 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Energy
6393f3d 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Temperature
9afd80d 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Dimensionless
75d0777 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Time
ceadbc8 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Length
09c2caa 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Pressure
b540d6c 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Mass
154e28f 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Frequency
1f3b807 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Density
76c9fe8 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:VolumetricFlowRate
81355ed 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Volume
3284a4b 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Intensity
0b7776c 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Illuminance
f4a4fbb 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Acceleration
03142ae 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:DataAmount
ebc2346 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:Area Number:ArealDensity
f3d6b00 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Number:DataTransferRate
e9a3a84 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
remaining fixes
536285f 
(both originally invalid)

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added (potentially) not backward compatible work in progress A PR that is not yet ready to be merged awaiting other PR Depends on another PR labels Feb 12, 2023
Hilbrand
Hilbrand requested changes Feb 12, 2023
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The units for a number of channels of the dsmr binding are not correct. Specifically all volume are not liters. But also not all energy channels have the correct unit. I have no time at the moment to give detailed feedback.

@J-N-K
Copy link
Member Author

J-N-K commented Feb 12, 2023

The units for a number of channels of the dsmr binding are not correct. Specifically all volume are not liters. But also not all energy channels have the correct unit. I have no time at the moment to give detailed feedback.

The unit in a channel definition is used as a replacement for the dimension and will be used only in UI to suggest a unit when creating a new item for a link. It has no technical functionality, so no harm will be done. If the user accepts the suggested item, it behaves like before when no state description was set with a unit that differs from the system default unit.

mlobstein
mlobstein reviewed Feb 16, 2023
View reviewed changes
bundles/org.openhab.binding.roku/src/main/resources/OH-INF/thing/roku.xml
@@ -175,7 +175,7 @@
</channel-type>

<channel-type id="signalQuality">
<item-type>Number:Dimensionless</item-type>
<item-type unit="%">Number</item-type>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't all the README files be updated to match?
image

@jlaur jlaur mentioned this pull request Feb 20, 2023
Merged
@J-N-K J-N-K closed this Mar 21, 2023
@J-N-K J-N-K mentioned this pull request Apr 18, 2023
Closed
@J-N-K J-N-K deleted the uom branch May 13, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlobstein mlobstein mlobstein left review comments

@Hilbrand Hilbrand Hilbrand requested changes

@mherwege mherwege Awaiting requested review from mherwege mherwege will be requested when the pull request is marked ready for review mherwege is a code owner

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange will be requested when the pull request is marked ready for review BjoernLange is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen will be requested when the pull request is marked ready for review ssalonen is a code owner

@mhilbush mhilbush Awaiting requested review from mhilbush mhilbush will be requested when the pull request is marked ready for review mhilbush is a code owner

@coop-git coop-git Awaiting requested review from coop-git coop-git will be requested when the pull request is marked ready for review coop-git is a code owner

@clinique clinique Awaiting requested review from clinique clinique will be requested when the pull request is marked ready for review clinique is a code owner

@BoBiene BoBiene Awaiting requested review from BoBiene BoBiene will be requested when the pull request is marked ready for review BoBiene is a code owner

@Skinah Skinah Awaiting requested review from Skinah Skinah will be requested when the pull request is marked ready for review Skinah is a code owner

@CSchlipp CSchlipp Awaiting requested review from CSchlipp CSchlipp will be requested when the pull request is marked ready for review CSchlipp is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv will be requested when the pull request is marked ready for review marcelrv is a code owner

@wborn wborn Awaiting requested review from wborn wborn will be requested when the pull request is marked ready for review wborn is a code owner

@hmerk hmerk Awaiting requested review from hmerk hmerk will be requested when the pull request is marked ready for review hmerk is a code owner

@jlaur jlaur Awaiting requested review from jlaur jlaur will be requested when the pull request is marked ready for review jlaur is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo will be requested when the pull request is marked ready for review lolodomo is a code owner

@jamesmelville jamesmelville Awaiting requested review from jamesmelville jamesmelville will be requested when the pull request is marked ready for review jamesmelville is a code owner

@Jamstah Jamstah Awaiting requested review from Jamstah Jamstah will be requested when the pull request is marked ready for review Jamstah is a code owner

@jannegpriv jannegpriv Awaiting requested review from jannegpriv jannegpriv will be requested when the pull request is marked ready for review jannegpriv is a code owner

@t2000 t2000 Awaiting requested review from t2000 t2000 will be requested when the pull request is marked ready for review t2000 is a code owner

@hww3 hww3 Awaiting requested review from hww3 hww3 will be requested when the pull request is marked ready for review hww3 is a code owner

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan will be requested when the pull request is marked ready for review digitaldan is a code owner

@cedricboon cedricboon Awaiting requested review from cedricboon cedricboon will be requested when the pull request is marked ready for review cedricboon is a code owner

@MatthiasKlocke MatthiasKlocke Awaiting requested review from MatthiasKlocke MatthiasKlocke will be requested when the pull request is marked ready for review MatthiasKlocke is a code owner

@bjoernbrings bjoernbrings Awaiting requested review from bjoernbrings bjoernbrings will be requested when the pull request is marked ready for review bjoernbrings is a code owner

@mgbowman mgbowman Awaiting requested review from mgbowman mgbowman will be requested when the pull request is marked ready for review mgbowman is a code owner

@roieg roieg Awaiting requested review from roieg roieg will be requested when the pull request is marked ready for review roieg is a code owner

@kjoglum kjoglum Awaiting requested review from kjoglum kjoglum will be requested when the pull request is marked ready for review kjoglum is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis will be requested when the pull request is marked ready for review kgoderis is a code owner

@nokyyz nokyyz Awaiting requested review from nokyyz nokyyz will be requested when the pull request is marked ready for review nokyyz is a code owner

@olivierkeke olivierkeke Awaiting requested review from olivierkeke olivierkeke will be requested when the pull request is marked ready for review olivierkeke is a code owner

@andrewfg andrewfg Awaiting requested review from andrewfg andrewfg will be requested when the pull request is marked ready for review andrewfg is a code owner

@renescherer renescherer Awaiting requested review from renescherer renescherer will be requested when the pull request is marked ready for review renescherer is a code owner

@fazioa fazioa Awaiting requested review from fazioa fazioa will be requested when the pull request is marked ready for review fazioa is a code owner

@chingon007 chingon007 Awaiting requested review from chingon007 chingon007 will be requested when the pull request is marked ready for review chingon007 is a code owner

@octa22 octa22 Awaiting requested review from octa22 octa22 will be requested when the pull request is marked ready for review octa22 is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 will be requested when the pull request is marked ready for review alexf2015 is a code owner

@pacive pacive Awaiting requested review from pacive pacive will be requested when the pull request is marked ready for review pacive is a code owner

@chaton78 chaton78 Awaiting requested review from chaton78 chaton78 will be requested when the pull request is marked ready for review chaton78 is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 will be requested when the pull request is marked ready for review markus7017 is a code owner

@seime seime Awaiting requested review from seime seime will be requested when the pull request is marked ready for review seime is a code owner

@hakan42 hakan42 Awaiting requested review from hakan42 hakan42 will be requested when the pull request is marked ready for review hakan42 is a code owner

@vctender vctender Awaiting requested review from vctender vctender will be requested when the pull request is marked ready for review vctender is a code owner

@itb3 itb3 Awaiting requested review from itb3 itb3 will be requested when the pull request is marked ready for review itb3 is a code owner

@druciak druciak Awaiting requested review from druciak druciak will be requested when the pull request is marked ready for review druciak is a code owner

@reyem reyem Awaiting requested review from reyem reyem will be requested when the pull request is marked ready for review reyem is a code owner

@ramack ramack Awaiting requested review from ramack ramack will be requested when the pull request is marked ready for review ramack is a code owner

@dougculnane dougculnane Awaiting requested review from dougculnane dougculnane will be requested when the pull request is marked ready for review dougculnane is a code owner

@andibraeu andibraeu Awaiting requested review from andibraeu andibraeu will be requested when the pull request is marked ready for review andibraeu is a code owner

@crnjan crnjan Awaiting requested review from crnjan crnjan will be requested when the pull request is marked ready for review crnjan is a code owner

@lsiepel lsiepel Awaiting requested review from lsiepel lsiepel will be requested when the pull request is marked ready for review lsiepel is a code owner

@Confectrician Confectrician Awaiting requested review from Confectrician Confectrician will be requested when the pull request is marked ready for review Confectrician is a code owner

@theater theater Awaiting requested review from theater theater will be requested when the pull request is marked ready for review theater is a code owner

@mvalla mvalla Awaiting requested review from mvalla mvalla will be requested when the pull request is marked ready for review mvalla is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp will be requested when the pull request is marked ready for review cweitkamp is a code owner

@ArjenKorevaar ArjenKorevaar Awaiting requested review from ArjenKorevaar ArjenKorevaar will be requested when the pull request is marked ready for review ArjenKorevaar is a code owner

@CrackerStealth CrackerStealth Awaiting requested review from CrackerStealth CrackerStealth will be requested when the pull request is marked ready for review CrackerStealth is a code owner

@FlorianSW FlorianSW Awaiting requested review from FlorianSW FlorianSW will be requested when the pull request is marked ready for review FlorianSW is a code owner

@psmedley psmedley Awaiting requested review from psmedley psmedley will be requested when the pull request is marked ready for review psmedley is a code owner

@aogorek aogorek Awaiting requested review from aogorek aogorek will be requested when the pull request is marked ready for review aogorek is a code owner

@ecdye ecdye Awaiting requested review from ecdye ecdye will be requested when the pull request is marked ready for review ecdye is a code owner

@EvilPingu EvilPingu Awaiting requested review from EvilPingu EvilPingu will be requested when the pull request is marked ready for review EvilPingu is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 will be requested when the pull request is marked ready for review pail23 is a code owner

@ntruchsess ntruchsess Awaiting requested review from ntruchsess ntruchsess will be requested when the pull request is marked ready for review ntruchsess is a code owner

@mrbig mrbig Awaiting requested review from mrbig mrbig will be requested when the pull request is marked ready for review mrbig is a code owner

@giovannimirulla giovannimirulla Awaiting requested review from giovannimirulla giovannimirulla will be requested when the pull request is marked ready for review giovannimirulla is a code owner

@fwolter fwolter Awaiting requested review from fwolter fwolter will be requested when the pull request is marked ready for review fwolter is a code owner

@bern77 bern77 Awaiting requested review from bern77 bern77 will be requested when the pull request is marked ready for review bern77 is a code owner

@weymann weymann Awaiting requested review from weymann weymann will be requested when the pull request is marked ready for review weymann is a code owner

@duhast duhast Awaiting requested review from duhast duhast will be requested when the pull request is marked ready for review duhast is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson will be requested when the pull request is marked ready for review cdjackson is a code owner

@9037568 9037568 Awaiting requested review from 9037568 9037568 will be requested when the pull request is marked ready for review 9037568 is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila will be requested when the pull request is marked ready for review paulianttila is a code owner

@thewiep thewiep Awaiting requested review from thewiep thewiep will be requested when the pull request is marked ready for review thewiep is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer will be requested when the pull request is marked ready for review kaikreuzer is a code owner

@sgiehl sgiehl Awaiting requested review from sgiehl sgiehl will be requested when the pull request is marked ready for review sgiehl is a code owner

@fa2k fa2k Awaiting requested review from fa2k fa2k will be requested when the pull request is marked ready for review fa2k is a code owner

@cschneider cschneider Awaiting requested review from cschneider cschneider will be requested when the pull request is marked ready for review cschneider is a code owner

@jsjames jsjames Awaiting requested review from jsjames jsjames will be requested when the pull request is marked ready for review jsjames is a code owner

@lewei50 lewei50 Awaiting requested review from lewei50 lewei50 will be requested when the pull request is marked ready for review lewei50 is a code owner

@Cossey Cossey Awaiting requested review from Cossey Cossey will be requested when the pull request is marked ready for review Cossey is a code owner

@bruestel bruestel Awaiting requested review from bruestel bruestel will be requested when the pull request is marked ready for review bruestel is a code owner

@Wire82 Wire82 Awaiting requested review from Wire82 Wire82 will be requested when the pull request is marked ready for review Wire82 is a code owner

@andylintner andylintner Awaiting requested review from andylintner andylintner will be requested when the pull request is marked ready for review andylintner is a code owner

@matchews matchews Awaiting requested review from matchews matchews will be requested when the pull request is marked ready for review matchews is a code owner

@gbicskei gbicskei Awaiting requested review from gbicskei gbicskei will be requested when the pull request is marked ready for review gbicskei is a code owner

@SamuelBrucksch SamuelBrucksch Awaiting requested review from SamuelBrucksch SamuelBrucksch will be requested when the pull request is marked ready for review SamuelBrucksch is a code owner

@trokohl trokohl Awaiting requested review from trokohl trokohl will be requested when the pull request is marked ready for review trokohl is a code owner

@Andy2003 Andy2003 Awaiting requested review from Andy2003 Andy2003 will be requested when the pull request is marked ready for review Andy2003 is a code owner

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 will be requested when the pull request is marked ready for review florian-h05 is a code owner

@fruggy83 fruggy83 Awaiting requested review from fruggy83 fruggy83 will be requested when the pull request is marked ready for review fruggy83 is a code owner

@sibbi77 sibbi77 Awaiting requested review from sibbi77 sibbi77 will be requested when the pull request is marked ready for review sibbi77 is a code owner

@limdul79 limdul79 Awaiting requested review from limdul79 limdul79 will be requested when the pull request is marked ready for review limdul79 is a code owner

@andrew-schofield andrew-schofield Awaiting requested review from andrew-schofield andrew-schofield will be requested when the pull request is marked ready for review andrew-schofield is a code owner

@pravussum pravussum Awaiting requested review from pravussum pravussum will be requested when the pull request is marked ready for review pravussum is a code owner

@caffineehacker caffineehacker Awaiting requested review from caffineehacker caffineehacker will be requested when the pull request is marked ready for review caffineehacker is a code owner

@DerOetzi DerOetzi Awaiting requested review from DerOetzi DerOetzi will be requested when the pull request is marked ready for review DerOetzi is a code owner

@boehan boehan Awaiting requested review from boehan boehan will be requested when the pull request is marked ready for review boehan is a code owner

@jpharvey jpharvey Awaiting requested review from jpharvey jpharvey will be requested when the pull request is marked ready for review jpharvey is a code owner

@gedejong gedejong Awaiting requested review from gedejong gedejong will be requested when the pull request is marked ready for review gedejong is a code owner

@MrRonfo MrRonfo Awaiting requested review from MrRonfo MrRonfo will be requested when the pull request is marked ready for review MrRonfo is a code owner

@david-pace david-pace Awaiting requested review from david-pace david-pace will be requested when the pull request is marked ready for review david-pace is a code owner

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker will be requested when the pull request is marked ready for review GerdZanker is a code owner

@jofleck jofleck Awaiting requested review from jofleck jofleck will be requested when the pull request is marked ready for review jofleck is a code owner

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister will be requested when the pull request is marked ready for review cpmeister is a code owner

@blafois blafois Awaiting requested review from blafois blafois will be requested when the pull request is marked ready for review blafois is a code owner

@Wolfgang1966 Wolfgang1966 Awaiting requested review from Wolfgang1966 Wolfgang1966 will be requested when the pull request is marked ready for review Wolfgang1966 is a code owner

@paphko paphko Awaiting requested review from paphko paphko will be requested when the pull request is marked ready for review paphko is a code owner

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb will be requested when the pull request is marked ready for review mgeramb is a code owner

@3cky 3cky Awaiting requested review from 3cky 3cky will be requested when the pull request is marked ready for review 3cky is a code owner

@aurelio1 aurelio1 Awaiting requested review from aurelio1 aurelio1 will be requested when the pull request is marked ready for review aurelio1 is a code owner

Assignees
No one assigned
Labels
awaiting other PR Depends on another PR (potentially) not backward compatible work in progress A PR that is not yet ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J-N-K @Hilbrand @mlobstein