Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsscripting] Fix node_modules handling #14398

Merged
merged 1 commit into from
Feb 18, 2023
Merged

[jsscripting] Fix node_modules handling #14398

merged 1 commit into from
Feb 18, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 15, 2023

@J-N-K
[jsscripting] Fix node_modules handling
d4ae2e4 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of an add-on awaiting other PR Depends on another PR regression Regression that happened during the development of a release. Not shown on final release notes. labels Feb 15, 2023
@J-N-K J-N-K requested a review from florian-h05 as a code owner February 15, 2023 12:14
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/176

florian-h05
florian-h05 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I have tested this, works fine.

@florian-h05 florian-h05 mentioned this pull request Feb 15, 2023
Closed
@florian-h05
Copy link
Contributor

@wborn Can you please review this PR and the core PR? JS Scripting is currently broken and this will fix it 😃

@J-N-K J-N-K mentioned this pull request Feb 15, 2023
Closed
4 tasks
@florian-h05 florian-h05 added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Feb 18, 2023
@florian-h05
Copy link
Contributor

@jlaur Can this get merged?
I have locally build this together with the core change and it works fine.

The CI build is failing because the core changes were merged today and I guess they aren‘t available in the core artifacts yet. If this gets merged today, JS Scripting should be fixed tomorrow (and we don‘t have to wait an additional day). In case the SNAPSHOT build of the addon fails, this is no great loss since JS Scripting is already broken.

Another option to speed this up is to get someone trigger the core build in Jenkins, I guess @kaikreuzer could help here.

@wborn
Copy link
Member

wborn commented Feb 18, 2023

I triggered a build. It will also allow for testing some Jenkins upgrades. 😄

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Feb 18, 2023
wborn
wborn approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wborn wborn merged commit 223deff into openhab:main Feb 18, 2023
@wborn wborn added this to the 4.0 milestone Feb 18, 2023
@J-N-K J-N-K deleted the fix-jsscripting branch February 20, 2023 08:04
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/177

nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@J-N-K @nemerdaud
[jsscripting] Fix node_modules handling (openhab#14398)
f904882 
Signed-off-by: Jan N. Klug <github@klug.nrw>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@J-N-K @renescherer
[jsscripting] Fix node_modules handling (openhab#14398)
b5e9df7 
Signed-off-by: Jan N. Klug <github@klug.nrw>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@J-N-K @FordPrfkt
[jsscripting] Fix node_modules handling (openhab#14398)
dc5f829 
Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@J-N-K @openhab-bot @florian-h05 @wborn