Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[innogysmarthome] Remove org.apache.commons #14407

Merged
merged 6 commits into from
Feb 26, 2023
Merged

[innogysmarthome] Remove org.apache.commons #14407

merged 6 commits into from
Feb 26, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 16, 2023

  • Remove apache.commons
  • Minor checkstyle fixes

Untested, only changes from code perspective.

@lsiepel
Remove org.apache
d6d6dd7 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Checkstyle
edec529 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from ollie-dev as a code owner February 16, 2023 20:28
@lsiepel lsiepel mentioned this pull request Feb 16, 2023
Open
@lsiepel
Fix comment
8fdbf5b 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Disable unnecessary verbose logging in test
70460e0 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Review comment
8fc2be0 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Correct var name
e8385ea 
Signed-off-by: lsiepel <leosiepel@gmail.com>
lolodomo
lolodomo reviewed Feb 26, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

.../test/java/org/openhab/binding/innogysmarthome/internal/handler/InnogyBridgeHandlerTest.java Show resolved Hide resolved
@lolodomo
Copy link
Contributor

@lsiepel : you introduced the method getRootThrowable in several bindings and I merged your PRs last week.
Can you please align them to the version from this PR ?
I find one in bindings ecobee and weathercompany.

lolodomo
lolodomo approved these changes Feb 26, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 6c7354b into openhab:main Feb 26, 2023
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 26, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 26, 2023
@lsiepel lsiepel deleted the innogy-apache branch February 26, 2023 09:59
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 26, 2023
@lsiepel
Alignment according to openhab#14407
9c56479 
Signed-off-by: lsiepel <leosiepel@gmail.com>
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 26, 2023
@lsiepel
Alignment according to openhab#14407
7941e5f 
Signed-off-by: lsiepel <leosiepel@gmail.com>
lolodomo pushed a commit that referenced this pull request Feb 26, 2023
@lsiepel
[weathercompany] Alignment according to #14407 (#14505)
8a433bd 
Signed-off-by: lsiepel <leosiepel@gmail.com>
lolodomo pushed a commit that referenced this pull request Feb 26, 2023
@lsiepel
[ecobee] Alignment according to #14407 (#14506)
d3d14d8 
Signed-off-by: lsiepel <leosiepel@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lsiepel @nemerdaud
[innogysmarthome] Remove org.apache.commons (openhab#14407)
8300e94 
Signed-off-by: lsiepel <leosiepel@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lsiepel @nemerdaud
[weathercompany] Alignment according to openhab#14407 (openhab#14505)
b452e10 
Signed-off-by: lsiepel <leosiepel@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lsiepel @nemerdaud
[ecobee] Alignment according to openhab#14407 (openhab#14506)
4eb823f 
Signed-off-by: lsiepel <leosiepel@gmail.com>
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
@lsiepel @miloit
[innogysmarthome] Remove org.apache.commons (openhab#14407)
c89e7db 
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: miloit <MichaelLoercher@web.de>
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
@lsiepel @miloit
[weathercompany] Alignment according to openhab#14407 (openhab#14505)
1dee389 
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: miloit <MichaelLoercher@web.de>
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
@lsiepel @miloit
[ecobee] Alignment according to openhab#14407 (openhab#14506)
4f5b821 
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: miloit <MichaelLoercher@web.de>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@lsiepel @renescherer
[innogysmarthome] Remove org.apache.commons (openhab#14407)
46798ba 
Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@lsiepel @renescherer
[weathercompany] Alignment according to openhab#14407 (openhab#14505)
6edd4d3 
Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@lsiepel @renescherer
[ecobee] Alignment according to openhab#14407 (openhab#14506)
105d654 
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@lsiepel @FordPrfkt
[innogysmarthome] Remove org.apache.commons (openhab#14407)
ac1949d 
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@lsiepel @FordPrfkt
[weathercompany] Alignment according to openhab#14407 (openhab#14505)
741d398 
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@lsiepel @FordPrfkt
[ecobee] Alignment according to openhab#14407 (openhab#14506)
2df9ab5 
Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@ollie-dev ollie-dev Awaiting requested review from ollie-dev

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lsiepel @lolodomo