Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[innogysmarthome] Remove org.apache.commons #14407

Merged
merged 6 commits into from
Feb 26, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 16, 2023

  • Remove apache.commons
  • Minor checkstyle fixes

Untested, only changes from code perspective.

Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

@lolodomo
Copy link
Contributor

@lsiepel : you introduced the method getRootThrowable in several bindings and I merged your PRs last week.
Can you please align them to the version from this PR ?
I find one in bindings ecobee and weathercompany.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 6c7354b into openhab:main Feb 26, 2023
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 26, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 26, 2023
@lsiepel lsiepel deleted the innogy-apache branch February 26, 2023 09:59
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 26, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 26, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
lolodomo pushed a commit that referenced this pull request Feb 26, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
lolodomo pushed a commit that referenced this pull request Feb 26, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: miloit <MichaelLoercher@web.de>
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: miloit <MichaelLoercher@web.de>
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: miloit <MichaelLoercher@web.de>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants