Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[irtrans] Remove org.apache.common #14408

Merged
merged 17 commits into from
Nov 6, 2023
Merged

[irtrans] Remove org.apache.common #14408

merged 17 commits into from
Nov 6, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 16, 2023 •
edited
Loading

  • Remove dependency on apache.commons
  • Improved the handlecommand due to allready refactoring
  • Fixed some checkstyle
  • Fixed some compile warnings.

Untested, minor refactoring from only from code perspective

@lsiepel
Remove org.apache.common
9ce0cbc 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel mentioned this pull request Feb 16, 2023
Open
@lsiepel
Copy link
Contributor Author

lsiepel commented Apr 7, 2023

@kgoderis are you able to review?

@jlaur jlaur added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label May 9, 2023
@lsiepel
Merge branch 'openhab:main' into irtrans-apache
0b21d23
@lsiepel
Fix wrong chomp alternative
545d9bc 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Merge branch 'irtrans-apache' of https://github.com/lsiepel/openhab-a…
28255d9 
…ddons into irtrans-apache
@lsiepel
Add annotation
d3f32c6 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Fix possible OutOfBoundsException
f51536f 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Fix another exception check
98ad61d 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Spotless
5e48286 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel added the work in progress A PR that is not yet ready to be merged label Aug 1, 2023
@lsiepel lsiepel mentioned this pull request Aug 1, 2023
Closed
26 tasks
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed work in progress A PR that is not yet ready to be merged rebuild Triggers Jenkins PR build labels Oct 15, 2023
@lsiepel lsiepel requested a review from a team October 20, 2023 17:24
jlaur
jlaur requested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I analyzed your code and the documentation, and I think this could be further improved.

...rtrans/src/main/java/org/openhab/binding/irtrans/internal/handler/EthernetBridgeHandler.java Outdated Show resolved Hide resolved
@lsiepel
address review comment
79a5071 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
jlaur requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Just a few comments left.

...nding.irtrans/src/main/java/org/openhab/binding/irtrans/internal/handler/BlasterHandler.java Outdated Show resolved Hide resolved
...nding.irtrans/src/main/java/org/openhab/binding/irtrans/internal/handler/BlasterHandler.java Show resolved Hide resolved
...nding.irtrans/src/main/java/org/openhab/binding/irtrans/internal/handler/BlasterHandler.java Outdated Show resolved Hide resolved
...rtrans/src/main/java/org/openhab/binding/irtrans/internal/handler/EthernetBridgeHandler.java Outdated Show resolved Hide resolved
@lsiepel
improved handlecommand
8eee75b 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Fix warnings
cdca50b 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
other handlecommand fix
4a6bbfe 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Minor SAT
9c676a4 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from jlaur October 30, 2023 22:05
@jlaur
Copy link
Contributor

jlaur commented Nov 3, 2023

@lsiepel - did you see my comment after the latest additional refactoring commit?

@lsiepel
Change warning fix
3e6d9c4 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Review comment
258135f 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
jlaur approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 4e7d736 into openhab:main Nov 6, 2023
3 checks passed
@jlaur jlaur added this to the 4.1 milestone Nov 6, 2023
@lsiepel lsiepel deleted the irtrans-apache branch November 6, 2023 20:02
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
@lsiepel @andrewfg
[irtrans] Remove org.apache.common (openhab#14408)
01987c3 
* Fix warnings

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lsiepel @austvik
[irtrans] Remove org.apache.common (openhab#14408)
2b7460e 
* Fix warnings

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees
No one assigned
Labels
additional testing preferred The change works for the pull request author. A test from someone else is preferred though.
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lsiepel @jlaur