[neeo] Remove org.apache.common

[lsiepel]

• Remove dependency on org.apache.commons

Untested, minor refactoring only from code perspective

[lsiepel]

@tmrobert8 are you able to review?

[morph166955]

I can probably test this. I may be one of the last neeo users at this point.

[mherwege]

I may be one of the last neeo users at this point.

You are not alone, still using it as well.

[morph166955]

Awesome, glad to know I'm not the lone ranger.

[morph166955]

@lsiepel What is the expected behavior that we are looking for to pass/fail this? I haven't looked at the code enough to see where the strings would be impacted with this. I'm loading the jar now.

[lsiepel]

for to pass/fail this? I haven't looked at the code enough to see where the strings would be impacted with this. I'm loading the jar now.

I would call it succesfull if you managed to discover, add and control things. At that point about all changed lines have been called. Maybe use it for some days to see if anything strange happens.

[morph166955]

Just to confirm, I'm only replacing the binding piece. Not the integration right.

[lsiepel]

Just to confirm, I'm only replacing the binding piece. Not the integration right.

Yes.

[morph166955]

I've dropped the jar in, it came up no errors so far. I'll use it for a few days to make sure it behaves as expected.

[morph166955]

The binding looked good last night when using the remote. I didn't see any issues.

[morph166955]

LGTM

[morph166955]

I'm fine with the proposed change assuming the dependencies on the core are obviously resolved.

[morph166955]

@lsiepel Why are some of the imports pointing to the neeo StringUtils and some are pointed to the openhab core StringUtils?

[lsiepel]

@lsiepel Why are some of the imports pointing to the neeo StringUtils and some are pointed to the openhab core StringUtils?

Because not all methods are available in the core utility class. Only the methods that are shared across multiple bindings are moved to core.

[jlaur]

Thanks! Two minor suggestions.

[jlaur]

LGTM