Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exec] Remove org.apache.common #14443

Merged
merged 8 commits into from
Oct 16, 2023
Merged

[exec] Remove org.apache.common #14443

merged 8 commits into from
Oct 16, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 18, 2023

  • Remove dependency on org.apache.commons

Untested, minor refactoring only from code perspective

Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from kgoderis as a code owner February 18, 2023 21:29
@lsiepel lsiepel requested a review from a team April 14, 2023 19:27
@jlaur jlaur added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label May 9, 2023
@lsiepel lsiepel requested a review from J-N-K July 27, 2023 09:11
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel added the work in progress A PR that is not yet ready to be merged label Aug 1, 2023
@lsiepel lsiepel removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. work in progress A PR that is not yet ready to be merged labels Oct 15, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close to finish line. 🙂 Can you fix the wrong import as well?

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 84db35d into openhab:main Oct 16, 2023
2 checks passed
@jlaur jlaur added this to the 4.1 milestone Oct 16, 2023
@lsiepel lsiepel deleted the exec-apache branch October 16, 2023 21:01
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants