Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exec] Remove org.apache.common #14443

Merged
merged 8 commits into from
Oct 16, 2023
Merged

[exec] Remove org.apache.common #14443

merged 8 commits into from
Oct 16, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 18, 2023

  • Remove dependency on org.apache.commons

Untested, minor refactoring only from code perspective

@lsiepel
Remove org.apache.common
53f35d7 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel mentioned this pull request Feb 18, 2023
Open
@lsiepel lsiepel requested a review from a team April 14, 2023 19:27
@jlaur jlaur added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label May 9, 2023
@lsiepel lsiepel requested a review from J-N-K July 27, 2023 09:11
@lsiepel
Improve class name
79ca1f5 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel added the work in progress A PR that is not yet ready to be merged label Aug 1, 2023
@lsiepel lsiepel mentioned this pull request Aug 1, 2023
Closed
26 tasks
@lsiepel lsiepel removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. work in progress A PR that is not yet ready to be merged labels Oct 15, 2023
jlaur
jlaur requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close to finish line. 🙂 Can you fix the wrong import as well?

...penhab.binding.exec/src/main/java/org/openhab/binding/exec/internal/handler/ExecHandler.java Outdated Show resolved Hide resolved
@lsiepel
Fix import
2787fc1 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Improve null check
98bd555 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
jlaur approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 84db35d into openhab:main Oct 16, 2023
3 checks passed
@jlaur jlaur added this to the 4.1 milestone Oct 16, 2023
@lsiepel lsiepel deleted the exec-apache branch October 16, 2023 21:01
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@lsiepel @querdenker2k
[exec] Remove org.apache.common (openhab#14443)
ed2234c 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@lsiepel @querdenker2k
[exec] Remove org.apache.common (openhab#14443)
9811b4e 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lsiepel @austvik
[exec] Remove org.apache.common (openhab#14443)
0e630fc 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lsiepel @J-N-K @jlaur