Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Add Siren capability to Presence Outdoor Camera #14485

Merged
merged 10 commits into from
Jul 13, 2023
Merged

[netatmo] Add Siren capability to Presence Outdoor Camera #14485

merged 10 commits into from
Jul 13, 2023

Conversation

clinique
Copy link
Contributor

Resolves #14466

@clinique clinique requested a review from lolodomo as a code owner February 23, 2023 08:44
@clinique clinique self-assigned this Feb 23, 2023
@clinique clinique added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Feb 23, 2023
@lolodomo
Copy link
Contributor

Shouldn't we wait for the merge of #14252 first to avoid conflicts ?

@clinique
Copy link
Contributor Author

Sure, there no urgency.

@clinique clinique force-pushed the netatmo_siren_14466 branch 2 times, most recently from 151d71e to f9f6f7d Compare March 10, 2023 14:54
@wborn wborn changed the title [Netatmo] Adding Siren capability to Presence Outdoor Camera [netatmo] Add Siren capability to Presence Outdoor Camera Mar 17, 2023
@lolodomo
Copy link
Contributor

lolodomo commented Mar 26, 2023 •
edited
Loading

@clinique : you have now to fix a conflict on README

@clinique clinique force-pushed the netatmo_siren_14466 branch from 31a87d6 to e1ff24a Compare March 27, 2023 13:23
@lolodomo
Copy link
Contributor

Still a conflict to solve.

What is the status about tests ? You are still waiting for the feedback from a user ?

@clinique
Copy link
Contributor Author

Still a conflict to solve.

What is the status about tests ? You are still waiting for the feedback from a user ?

Yes, my Presence does not have any siren - so I would like a clear "it works"

clinique added 7 commits April 23, 2023 13:10
@clinique
Adding Siren capability to Presence Outdoor Camera
8047693 
Resolves openhab#14466

Signed-off-by: clinique <gael@lhopital.org>
@clinique
Rebased and investigate
f6dd2b2 
Adding Siren capability to Presence Outdoor Camera
Resolves openhab#14466

Signed-off-by: clinique <gael@lhopital.org>
@clinique
Adding some debuggings
74caafc 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Enhancing debugging
ca7ce80 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Code review corrections
f7ede55 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Correcting addition of thingTypeVersion
620faa2 
Reviewing @lolodomo comment => properties file regenerated, must be correct.

Signed-off-by: clinique <gael@lhopital.org>
@clinique
Rebased
80d3dad 
Adding Siren capability to Presence Outdoor Camera
Resolves openhab#14466

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique force-pushed the netatmo_siren_14466 branch from e1ff24a to 80d3dad Compare April 23, 2023 11:13
@clinique
Copy link
Contributor Author

@lolodomo : rebased

@clinique
Forgot this
aa089c7 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Moved and corrected instructions.xml
fa1b5ec 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Adding group id
07e578e 
Signed-off-by: clinique <gael@lhopital.org>
lolodomo
lolodomo approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

lolodomo commented May 5, 2023

In addition to a successful test of this change by a user, we are also waiting for the merge of PR openhab/openhab-core#3576.

@lolodomo lolodomo added the awaiting other PR Depends on another PR label May 5, 2023
@lolodomo
Copy link
Contributor

lolodomo commented May 7, 2023

Core PR has just been merged.

@lolodomo lolodomo removed the awaiting other PR Depends on another PR label May 7, 2023
@jlaur
Copy link
Contributor

jlaur commented Jun 17, 2023

@lolodomo, @clinique - anything left to do here? Do you have any user to test the changes?

@clinique
Copy link
Contributor Author

Let's assume it works...

@jlaur
Copy link
Contributor

jlaur commented Jul 13, 2023

@lolodomo - did you see @clinique's latest comment?

@lolodomo
Copy link
Contributor

No but now I see it :)

@lolodomo lolodomo merged commit 1942dfe into openhab:main Jul 13, 2023
@lolodomo lolodomo added this to the 4.0 milestone Jul 13, 2023
@clinique clinique deleted the netatmo_siren_14466 branch July 13, 2023 16:40
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@clinique @austvik
[netatmo] Add Siren capability to Presence Outdoor Camera (openhab#14485
f3d495d 
)

* Adding Siren capability to Presence Outdoor Camera
Resolves openhab#14466

---------

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur left review comments

@J-N-K J-N-K J-N-K left review comments

@lolodomo lolodomo lolodomo approved these changes

Assignees

@clinique clinique

Labels
additional testing preferred The change works for the pull request author. A test from someone else is preferred though. enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[Netatmo] Supporting siren on Netatmo Presence Outdoor Camera with Siren
4 participants
@clinique @lolodomo @jlaur @J-N-K