-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Netatmo] Fix Floodlight issue on Presence Camera #14492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clinique <gael@lhopital.org>
…y points. I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one). Signed-off-by: clinique <gael@lhopital.org>
clinique
added
bug
An unexpected problem or unintended behavior of an add-on
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
labels
Feb 24, 2023
clinique
changed the title
[Netatmo] floodlight 14458
[Netatmo] Floodlight issue on Presence Camera
Feb 24, 2023
lolodomo
approved these changes
Feb 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
@clinique : you want to wait for a user feedback before merging ? |
Yes, I'm unable to ensure that what I did works really, so I would prefer have somebody (@multimartin) validate this. |
Confirmed to work in the issue. |
lolodomo
removed
the
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
label
Feb 27, 2023
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Solving issue openhab#14458 Signed-off-by: clinique <gael@lhopital.org> * Removes the usage of "app.netatmo.net" since api now holds these entry points. I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one). -------- Signed-off-by: clinique <gael@lhopital.org>
miloit
pushed a commit
to miloit/openhab-addons
that referenced
this pull request
Mar 10, 2023
* Solving issue openhab#14458 Signed-off-by: clinique <gael@lhopital.org> * Removes the usage of "app.netatmo.net" since api now holds these entry points. I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one). -------- Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: miloit <MichaelLoercher@web.de>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* Solving issue openhab#14458 Signed-off-by: clinique <gael@lhopital.org> * Removes the usage of "app.netatmo.net" since api now holds these entry points. I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one). -------- Signed-off-by: clinique <gael@lhopital.org>
jlaur
changed the title
[Netatmo] Floodlight issue on Presence Camera
[Netatmo] Fix Floodlight issue on Presence Camera
Apr 11, 2023
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* Solving issue openhab#14458 Signed-off-by: clinique <gael@lhopital.org> * Removes the usage of "app.netatmo.net" since api now holds these entry points. I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one). -------- Signed-off-by: clinique <gael@lhopital.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14458
Removes the usage of "app.netatmo.net" since api now holds these entry points.
I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one).