Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Netatmo] Fix Floodlight issue on Presence Camera #14492

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Feb 24, 2023

Resolves #14458

Removes the usage of "app.netatmo.net" since api now holds these entry points.
I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one).

Signed-off-by: clinique <gael@lhopital.org>
…y points.

I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one).

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Feb 24, 2023
@clinique clinique requested a review from lolodomo as a code owner February 24, 2023 14:50
@clinique clinique self-assigned this Feb 24, 2023
@clinique clinique changed the title [Netatmo] floodlight 14458 [Netatmo] Floodlight issue on Presence Camera Feb 24, 2023
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

@clinique : you want to wait for a user feedback before merging ?

@clinique
Copy link
Contributor Author

Yes, I'm unable to ensure that what I did works really, so I would prefer have somebody (@multimartin) validate this.

@lolodomo
Copy link
Contributor

Confirmed to work in the issue.

@lolodomo lolodomo merged commit c95380f into openhab:main Feb 27, 2023
@lolodomo lolodomo removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Feb 27, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 27, 2023
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* Solving issue openhab#14458

Signed-off-by: clinique <gael@lhopital.org>

* Removes the usage of "app.netatmo.net" since api now holds these entry points.
I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one).

--------

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique deleted the netatmo_floodlight_14458 branch March 2, 2023 09:53
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
* Solving issue openhab#14458

Signed-off-by: clinique <gael@lhopital.org>

* Removes the usage of "app.netatmo.net" since api now holds these entry points.
I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one).

--------

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: miloit <MichaelLoercher@web.de>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* Solving issue openhab#14458

Signed-off-by: clinique <gael@lhopital.org>

* Removes the usage of "app.netatmo.net" since api now holds these entry points.
I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one).

--------

Signed-off-by: clinique <gael@lhopital.org>
@jlaur jlaur changed the title [Netatmo] Floodlight issue on Presence Camera [Netatmo] Fix Floodlight issue on Presence Camera Apr 11, 2023
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* Solving issue openhab#14458

Signed-off-by: clinique <gael@lhopital.org>

* Removes the usage of "app.netatmo.net" since api now holds these entry points.
I think it was the origin of malfunction of floodlight (to be controlled by somebody who has one).

--------

Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Netatmo] Floodlight not working on Presence Camera (with siren)
2 participants